feat: reset filters in worksheets and block captions - #690

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/mosaic/src/dashboard/toolbar/MosaicDashboardAddPanelDropdown.tsx`:
- Around line 30-36: The icon-only add-panel Button in
MosaicDashboardAddPanelDropdown.tsx lacks an accessible name; update the Button
(the one rendering <Plus /> inside) to provide an explicit accessible label
(e.g., add aria-label="Add panel" or aria-label based on localized text) or hook
it to a visually hidden text/aria-labelledby so assistive tech can announce it;
ensure the label string is descriptive and, if applicable, uses existing
i18n/localization utilities in the component.

In
`@packages/mosaic/src/data-table-explorer/dashboard/MosaicDashboardDataTableExplorerPanelRenderer.tsx`:
- Around line 31-35: The code calls useDataTableExplorer with a non-null
asserted selectedTable (selectedTable!) which can be undefined; change the call
to pass selectedTable (no !) so tableName can be undefined, and update the hook
useDataTableExplorer (and downstream helpers it uses) to accept tableName?:
string and return a safe no-op explorer state when tableName is undefined (e.g.,
empty data, loading=false, no-op selection handlers) so the component can render
safely; alternatively, if you prefer not to change the hook, move rendering of
MosaicDashboardDataTableExplorerPanelRenderer up so it is not mounted when
selectedTable is falsy, but do not use a non-null assertion inside this
component.

In
`@packages/mosaic/src/data-table-explorer/hooks/useDataTableExplorerSelection.ts`:
- Around line 53-61: The hook creates fallbackSelection eagerly causing
selection identity to change once existingSelection is registered; update
useDataTableExplorerSelection to either (A) stop creating an immediate
fallbackSelection and let selection be providedSelection ?? existingSelection ??
MosaicSelection.crossfilter() inline so the effect's getSelection call supplies
the same instance, or (B) if the store API allows, synchronously obtain/register
the selection by calling getSelection(selectionKey, 'crossfilter') during
initialization and use that returned instance as fallbackSelection—adjust
references to fallbackSelection, getSelection, existingSelection,
providedSelection, and selectionKey accordingly to ensure a stable selection
object identity across renders.

---

Nitpick comments:
In `@packages/deck/src/dashboard.tsx`:
- Around line 129-130: The clients array passed to usePanelClientRegistration is
recreated each render causing its effect to re-run; fix by memoizing the array
before calling usePanelClientRegistration (e.g. create a stable "clients" value
derived from "client" using useMemo or a ref) and pass that memoized "clients"
into usePanelClientRegistration(dashboard.id, panel.id, clients) so the
reference only changes when "client" actually changes.

In `@packages/mosaic/src/dashboard/MosaicDashboardSlice.ts`:
- Around line 983-1007: The code does three separate state updates in
removePanel—deleting mosaicDashboard.runtime.panelClients[key], calling
get().mosaicDashboard.evictPanelRuntime(dashboardId, panelId), and updating the
dashboards config (dashboard.panels, dashboard.layout, dashboard.updatedAt);
consolidate the two direct state mutations into a single set(produce(...)) call
to avoid intermediate renders by: build one produce block that deletes
state.mosaicDashboard.runtime.panelClients[getMosaicDashboardPanelId(dashboardId,
panelId)] and updates the corresponding dashboard (filter panels, call
removePanelFromLayout, set updatedAt) in the same draft, and keep
get().mosaicDashboard.evictPanelRuntime(dashboardId, panelId) as an external
side-effect call (before or after the combined set) so runtime eviction still
runs but state mutations happen atomically.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/mosaic/src/charts/chart-settings/MosaicChartTypeSelector.tsx`:
- Around line 46-47: Selected chart type labels are optional and can render
empty spans; update the render in MosaicChartTypeSelector (the trigger span
using selectedChartType.label and the list row span using chartType.label) to
fall back to the chart id by using the nullish fallback (e.g., "?? chartType.id"
/ "?? selectedChartType.id") so the UI always shows a non-empty identifier.

In `@packages/mosaic/src/components/useCombobox.ts`:
- Around line 3-6: The generic T for UseComboboxOptions/useCombobox should be
constrained to string because selection flow (handleSelect) and
Combobox/Combobox.Item use string values; change the signature to use T extends
string (e.g. UseComboboxOptions<T extends string>) and update useCombobox's
generic accordingly so value: T and onChange: (value: T) => void are truly
string-based, then remove any unsafe casts like value as T in handleSelect and
let TypeScript enforce string types end-to-end.