Repository navigation
feat: Upgrade DuckDB to 1.5.3 - #659
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughBumps ChangesJavaScript/TypeScript DuckDB Updates
Python DuckDB Version Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ilyabo
marked this pull request as ready for review
May 21, 2026 21:59
ilyabo
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 113: The root package.json pins the dependency "`@duckdb/duckdb-wasm`" to
the dev tag "1.33.1-dev55.0" which propagates across the workspace; either
confirm and document that this dev build is intentionally required
workspace-wide or replace the pinned dev tag with a stable/GA release (e.g.,
"1.33.1" or a caret range) everywhere it appears (root package.json, examples/**
package.json files, and packages/duckdb package.json) and then regenerate the
lockfile (run pnpm install) so pnpm-lock.yaml reflects the new specifier; update
any workspace README or package documentation to note the intentional dev pin if
you choose to keep it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: db0fde92-287a-4979-9e42-705793f6dc4d
⛔ Files ignored due to path filters (4)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlpython/sqlrooms-cli/uv.lockis excluded by!**/*.lockpython/sqlrooms-server/uv.lockis excluded by!**/*.lockpython/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (22)
apps/sqlrooms-cli-ui/package.jsonexamples/ai-agent/package.jsonexamples/ai-core/package.jsonexamples/ai-rag/package.jsonexamples/ai-subagents/package.jsonexamples/ai/package.jsonexamples/app-builder/package.jsonexamples/cosmos-embedding/package.jsonexamples/cosmos/package.jsonexamples/layout/package.jsonexamples/mosaic/package.jsonexamples/nextjs/package.jsonexamples/pivot/package.jsonexamples/query-pwa/package.jsonexamples/query-pwa/src/main.tsxexamples/query-websocket/package.jsonexamples/query/package.jsonpackage.jsonpackages/duckdb/package.jsonpython/pyproject.tomlpython/sqlrooms-cli/pyproject.tomlpython/sqlrooms-server/pyproject.toml
💤 Files with no reviewable changes (2)
- apps/sqlrooms-cli-ui/package.json
- examples/query-pwa/src/main.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
@duckdb/duckdb-wasmto 1.33.1-dev55.0 across projects and examples