Skip to content

refactor: Fold local agent chat into Chat - #635

Merged
ilyabo merged 2 commits into
mihajlo/skills-and-wizardfrom
codex/fold-local-agent-chat
May 18, 2026
Merged

ilyabo merged 2 commits into
mihajlo/skills-and-wizardfrom
codex/fold-local-agent-chat

Conversation

@ilyabo

@ilyabo ilyabo commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the standalone AgentChat implementation with Chat.LocalAgentRoot on the existing compound Chat API.
  • Route Chat.Messages, Chat.Composer, and Chat.PromptSuggestions through a runtime context so session chat behavior stays unchanged while local-agent chat uses local useChat state.
  • Update skill authoring to compose Chat.LocalAgentRoot, remove the separate agent-chat export/files, and fix the missing CompositeSkillStorage root export.

Validation

  • pnpm build
  • pnpm typecheck
  • pnpm --filter @sqlrooms/ai-core test
  • pnpm --filter @sqlrooms/ai --filter @sqlrooms/ai-core --filter ai-agent-example lint
  • pnpm --filter ai-agent-example build
  • Pre-push hook also ran knip, full pnpm typecheck, and full pnpm test successfully.

Notes

  • Base branch is mihajlo/skills-and-wizard.
  • Draft PR because this is a follow-up refactor on an in-flight feature branch.

@coderabbitai

coderabbitai Bot commented May 18, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f33a45b4-b444-4304-90e2-67ec97838cb1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fold-local-agent-chat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ilyabo ilyabo changed the title [codex] Fold local agent chat into Chat refactor: Fold local agent chat into Chat May 18, 2026
@ilyabo
ilyabo marked this pull request as ready for review May 18, 2026 16:56
@ilyabo
ilyabo requested a review from mihajlo-stojkovic May 18, 2026 16:56
@ilyabo
ilyabo merged commit 1fa00ef into mihajlo/skills-and-wizard May 18, 2026
3 checks passed
@ilyabo
ilyabo deleted the codex/fold-local-agent-chat branch May 18, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant