fix: Pass AI run context into dashboard chart tool resolution by ilyabo · Pull Request #627 · sqlrooms/sqlrooms

ilyabo · 2026-05-14T20:53:39Z

Summary by CodeRabbit

New Features
- Chart tools now accept an execution context so tools can infer the active dashboard/artifact and table from runtime AI session data when not explicitly provided.
Documentation
- Added docs describing how execution context influences resource resolution and examples for using chart tools with AI run/session context.

coderabbitai · 2026-05-14T20:53:51Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eea3cbef-75a7-4c74-a96e-2c6cab8457f4

📥 Commits

Reviewing files that changed from the base of the PR and between 5d7cd16 and 7a1c104.

📒 Files selected for processing (2)

packages/mosaic/README.md
packages/mosaic/src/index.ts

✅ Files skipped from review due to trivial changes (1)

packages/mosaic/README.md

📝 Walkthrough

Walkthrough

Chart tools now support optional execution context for resource resolution. A new ChartToolExecutionContext type carries session and AI run metadata; resolveResources accepts this context as a second parameter, enabling implicit dashboard artifacts to be derived from run contexts instead of only live UI state defaults.

Changes

Chart Tool Execution Context

Layer / File(s)	Summary
Context type contract and resolver signature `packages/mosaic/src/chart-types/base-types.ts`, `packages/mosaic/src/index.ts`	New `ChartToolExecutionContext` type with optional `sessionId` and `aiRunContext` fields; `ChartToolDeps.resolveResources` updated from single `params` to separate `(params, context?)` signature; barrel export exposes the new type.
Context resolution logic `apps/sqlrooms-cli-ui/src/createChartToolDeps.ts`	Import context type; add `getRunContextDashboardArtifactId` helper to extract dashboard artifact from run context; update `resolveArtifact` to prefer context-derived artifact id when `artifactId` not explicitly provided; thread `context` through `resolveResources`.
Chart tool context threading `packages/mosaic/src/chart-types/{box-plot,count-plot,heatmap,line-chart,bubble-chart,histogram}/tool.ts`	All six chart tools updated to accept `context` parameter in `execute` handler and forward it to `deps.resolveResources(params, context)`.
AI Chart Tools documentation `packages/mosaic/README.md`	New section explaining `createChartTools` artifact resolution with context, guidance on using execution-scoped context over live UI state, and precedence of explicit `params.artifactId`; includes a TypeScript example.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

dmitriy-kostianetskiy

Poem

🐰 A context now flows through the charts so bright,
AI run whispers guide the artifact light,
Six tools dance in sync, their signatures new,
From type to implementation, the story rings true,
No dashboard assumed—just let context choose! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding AI run context parameter to chart tool resolution logic across multiple files and implementing context-aware artifact resolution.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-chart-tool-target-resolution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

packages/mosaic/README.md (1)
229-237: ⚡ Quick win

Consider adding a code example for consistency.

Other sections in this README (useMosaicClient, Mosaic Profiler, Dashboard Panels, Chart Builder) include code examples. Adding a brief example showing how createChartTools is used and how the execution context flows through resolveResources would improve consistency and help developers understand the feature.

Example structure you might consider:

Show createChartTools with a resolveResources callback

Demonstrate accessing context.sessionId and context.aiRunContext

Illustrate the fallback from execution context to explicit params.artifactId

As per coding guidelines: "When changing the public API of an @sqlrooms/* package or adding new public API, update the package's README.md accordingly"—the current documentation meets this requirement, but examples are a pattern established elsewhere in this README.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/mosaic/README.md` around lines 229 - 237, Add a small code example
to the "AI Chart Tools" section showing how to call createChartTools and provide
a ChartToolDeps.resolveResources callback that receives (params, context),
demonstrates reading context.sessionId and context.aiRunContext, and shows that
an explicit params.artifactId takes precedence over any values derived from the
execution context; include a brief comment or note in the example that
execution-scoped context is preferred over live UI state when resolving implicit
dashboard targets.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/mosaic/README.md`:
- Around line 229-237: Add a small code example to the "AI Chart Tools" section
showing how to call createChartTools and provide a
ChartToolDeps.resolveResources callback that receives (params, context),
demonstrates reading context.sessionId and context.aiRunContext, and shows that
an explicit params.artifactId takes precedence over any values derived from the
execution context; include a brief comment or note in the example that
execution-scoped context is preferred over live UI state when resolving implicit
dashboard targets.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 82c225c9-d128-44c2-b6ef-4c1a16832f9f

📥 Commits

Reviewing files that changed from the base of the PR and between 1332308 and 5d7cd16.

📒 Files selected for processing (9)

apps/sqlrooms-cli-ui/src/createChartToolDeps.ts
packages/mosaic/README.md
packages/mosaic/src/chart-types/base-types.ts
packages/mosaic/src/chart-types/box-plot/tool.ts
packages/mosaic/src/chart-types/bubble-chart/tool.ts
packages/mosaic/src/chart-types/count-plot/tool.ts
packages/mosaic/src/chart-types/heatmap/tool.ts
packages/mosaic/src/chart-types/histogram/tool.ts
packages/mosaic/src/chart-types/line-chart/tool.ts

Pass AI run context into dashboard chart tool resolution

5d7cd16

Thread AI chart tools through execution context

c61711e

coderabbitai Bot reviewed May 14, 2026

View reviewed changes

Document chart tool execution context in mosaic README

7a1c104

ilyabo merged commit 229b4d1 into main May 15, 2026
1 of 3 checks passed

ilyabo deleted the fix-chart-tool-target-resolution branch May 15, 2026 19:49

This was referenced May 20, 2026

feat: Add primary artifact run context tools #646

Merged

feat: ai powered dashboards #634

Merged

feat: Deck map ai tool #654

Merged

coderabbitai Bot mentioned this pull request May 28, 2026

feat: Add tables to AI agent context #664

Merged

coderabbitai Bot mentioned this pull request Jun 10, 2026

feat: Add per-session draft AI context state #707

Merged

coderabbitai Bot mentioned this pull request Jun 20, 2026

fix: dashboard chart panel updates #736

Merged

Navigation Menu

Repository navigation

fix: Pass AI run context into dashboard chart tool resolution - #627

fix: Pass AI run context into dashboard chart tool resolution#627
ilyabo merged 3 commits into
mainfrom
fix-chart-tool-target-resolution

ilyabo commented May 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 14, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ilyabo commented May 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ilyabo commented May 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 14, 2026 •

edited

Loading