Skip to content

feat: remove eCDF chart - #608

Merged
dmitriy-kostianetskiy merged 1 commit into
mainfrom
remove-ecdf
May 11, 2026
Merged

feat: remove eCDF chart#608
dmitriy-kostianetskiy merged 1 commit into
mainfrom
remove-ecdf

Conversation

@dmitriy-kostianetskiy

@dmitriy-kostianetskiy dmitriy-kostianetskiy commented May 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Removed ECDF (Empirical Cumulative Distribution Function) chart type and all associated functionality from the library, including chart configuration, user interface components, specification generation, AI tool support, and test cases. This chart type is no longer available for use within the application.

Review Change Stack

@dmitriy-kostianetskiy dmitriy-kostianetskiy self-assigned this May 11, 2026
@coderabbitai

coderabbitai Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d46c18b4-1f89-494b-8e16-0b1540dd84b5

📥 Commits

Reviewing files that changed from the base of the PR and between 278d244 and 0966946.

📒 Files selected for processing (11)
  • packages/mosaic/__tests__/ChartSettings.test.tsx
  • packages/mosaic/__tests__/generateMosaicChartSpec.test.ts
  • packages/mosaic/src/chart-types/chart-config.ts
  • packages/mosaic/src/chart-types/ecdf/EcdfSettings.tsx
  • packages/mosaic/src/chart-types/ecdf/definition.ts
  • packages/mosaic/src/chart-types/ecdf/schema.ts
  • packages/mosaic/src/chart-types/ecdf/spec.ts
  • packages/mosaic/src/chart-types/ecdf/tool.ts
  • packages/mosaic/src/chart-types/index.ts
  • packages/mosaic/src/chart-types/registry.ts
  • packages/mosaic/src/index.ts
💤 Files with no reviewable changes (10)
  • packages/mosaic/src/chart-types/ecdf/EcdfSettings.tsx
  • packages/mosaic/src/chart-types/chart-config.ts
  • packages/mosaic/src/chart-types/registry.ts
  • packages/mosaic/src/chart-types/ecdf/spec.ts
  • packages/mosaic/src/chart-types/ecdf/schema.ts
  • packages/mosaic/tests/generateMosaicChartSpec.test.ts
  • packages/mosaic/src/index.ts
  • packages/mosaic/src/chart-types/ecdf/definition.ts
  • packages/mosaic/src/chart-types/ecdf/tool.ts
  • packages/mosaic/tests/ChartSettings.test.tsx
📝 Walkthrough

Walkthrough

This PR removes the ECDF (Empirical Cumulative Distribution Function) chart type entirely from the Mosaic chart library. It deletes all related schemas, React components, chart specifications, AI tool integrations, type definitions, and public API exports while updating the chart registry and tests accordingly.

Changes

ECDF Chart Type Removal

Layer / File(s) Summary
ECDF Schema & Type Definitions
packages/mosaic/src/chart-types/ecdf/schema.ts		 Removes Zod schemas for EcdfChartSettings and EcdfChartConfig types.
ECDF Settings Component
packages/mosaic/src/chart-types/ecdf/EcdfSettings.tsx		 Deletes the React component that rendered ECDF field selection UI.
ECDF Chart Type Definition
packages/mosaic/src/chart-types/ecdf/definition.ts		 Removes the ecdfChartType definition that wired schema, UI, spec, and tool.
ECDF Spec Generator
packages/mosaic/src/chart-types/ecdf/spec.ts		 Deletes createEcdfSpec function that generated cumulative chart specs.
ECDF AI Tool
packages/mosaic/src/chart-types/ecdf/tool.ts		 Removes AI tool parameters, types, and factory for ECDF chart creation.
Chart Config Type Union Update
packages/mosaic/src/chart-types/chart-config.ts		 Removes EcdfChartConfig from VgPlotChartConfig discriminated union and its import.
Chart Type Registry & Index
packages/mosaic/src/chart-types/registry.ts, packages/mosaic/src/chart-types/index.ts		 Removes ECDF imports, registration, and re-exports; expands exports for heatmap, box-plot, bubble-chart, and custom-spec; updates mosaicChartTypes and createDefaultChartTypes().
Public API Exports
packages/mosaic/src/index.ts		 Removes all ECDF-related exports from the library's public API surface.
Tests
packages/mosaic/__tests__/ChartSettings.test.tsx, packages/mosaic/__tests__/generateMosaicChartSpec.test.ts		 Removes ECDF entries from chart type iteration and ECDF spec generation test case.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • sqlrooms/sqlrooms#591: Adds ECDF chart type surface (schemas, settings, spec, tools, index exports) which this PR removes.
  • sqlrooms/sqlrooms#581: Adds ECDF chart schemas/definitions and includes ECDF in tests and type unions; this PR reverses those changes.

Suggested reviewers

  • ilyabo

Poem

🐰 Away goes the ECDF, with cumulative grace,
No more empirical distributions in this space!
The schema, the tool, the spec all removed,
The codebase is cleaner, better groomed!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: remove eCDF chart' directly and clearly summarizes the main change: removing the eCDF chart type implementation across the codebase.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-ecdf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dmitriy-kostianetskiy
dmitriy-kostianetskiy merged commit 733d8d5 into main May 11, 2026
4 checks passed
@dmitriy-kostianetskiy
dmitriy-kostianetskiy deleted the remove-ecdf branch May 11, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyabo ilyabo ilyabo approved these changes

Assignees

See More

@dmitriy-kostianetskiy dmitriy-kostianetskiy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitriy-kostianetskiy @ilyabo