Skip to content

fix: fix zindex of dialog content - #600

Closed
bdjulbic wants to merge 8 commits into
mainfrom
fix/fix-zindex-of-dialog-content
Closed

fix: fix zindex of dialog content#600
bdjulbic wants to merge 8 commits into
mainfrom
fix/fix-zindex-of-dialog-content

Conversation

@bdjulbic

@bdjulbic bdjulbic commented May 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Fix the ordering z-index of the dialogs

Summary by CodeRabbit

  • New Features

    • ActivityBox now supports collapsible summaries to expand/collapse activity displays
    • Tool completion summaries display in analysis results when tasks complete
    • Map legend supports split-pane toggle mode for improved layout control
    • Tool reasoning displays above Vega charts when available

  • Improvements

    • Enhanced z-index stacking order for overlays, dropdowns, popovers, and tooltips across the UI
    • Map legend panel accepts custom close handler for better integration

@coderabbitai

coderabbitai Bot commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR extends ActivityBox with optional collapsible summaries that track per-label expansion state; integrates summary labels into AnalysisResult and FlatAgentRenderer for completed tool groups; adds split-pane mode to map legend components with callback-based close handling; elevates z-index stacking across dialog, dropdown, menu, popover, and tooltip overlays; displays tool input reasoning in VegaChartToolResult; and simplifies mosaic table interop type handling.

Changes

Activity Display Collapsibility & Integration

Layer / File(s) Summary
ActivityBox Props & State Contract
packages/ai-core/src/components/ActivityBox.tsx		 summaryLabel?: string prop added; expandedForLabel state tracks per-label expansion; visible flag derives from label and expansion state.
ActivityBox Collapsed & Expanded Rendering
packages/ai-core/src/components/ActivityBox.tsx		 When collapsed, renders right-chevron summary button; when visible and not running, adds down-chevron collapse button; scroll listener wired to visibility dependency.
ActivityBox Content Styling
packages/ai-core/src/components/ActivityBox.tsx		 Inner content className updated to include hyphens-auto for improved word-based line breaking.
Tool Group Summary Integration
packages/ai-core/src/components/AnalysisResult.tsx, packages/ai-core/src/components/FlatAgentRenderer.tsx		 AnalysisResult computes toolCount and allToolsDone; FlatSegmentList accepts isAgentComplete and derives summaryLabel when complete; FlatAgentRenderer forwards completion status; summaryLabels passed into ActivityBox.
Activity & Orchestrator Log Line Text Wrapping
packages/ai-core/src/components/FlatAgentRenderer.tsx		 ActivityLogLine and OrchestratorLogLineInner updated from break-all to break-words hyphens-auto for improved word-based line breaking.

Map Legend Split Pane & Callback Routing

Layer / File(s) Summary
Map Legend Callback Interface
packages/kepler/src/components/CustomMapLegend.tsx		 MapLegend props extended with optional onClose?: () => void; handleClose conditionally invokes callback or dispatches toggle action.
Map Legend Panel Split Mode
packages/kepler/src/components/CustomMapLegendPanel.tsx		 CustomMapLegendPanelFactory rewritten to accept explicit component factories; supports isSplit mode with internal toggle state and tooltip-wrapped button for legend open/close.
Kepler Map Container Legend State Override
packages/kepler/src/components/KeplerMapContainer.tsx		 bottomWidgetFields computed via useMemo; when enabled, overrides mapLegend.active to false while preserving show and other mapControls state.

UI Z-Index Stacking & Other Updates

Layer / File(s) Summary
UI Component Z-Index Stacking Updates
packages/ui/src/components/dialog.tsx, context-menu.tsx, dropdown-menu.tsx, hover-card.tsx, menu-bar.tsx, popover.tsx, select.tsx, tooltip.tsx		 Dialog overlay/content raised from z-50 to z-1000; dropdown, context menu, hover card, menu bar, popover, select, and tooltip content raised to z-1100 for proper modal and overlay layering.
Mosaic Interop & Vega Chart Reasoning
packages/mosaic/src/tableInterop.ts, packages/vega/src/VegaChartToolResult.tsx		 createMosaicTableFromArrowTable returns attachTableInterop result directly without type assertion; VegaChartToolResult conditionally renders input.reasoning as small muted text above chart container.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • ilyabo
  • mihajlo-stojkovic

Poem

🐰 A collapsible box springs to life,
with summaries hiding the strife,
While charts show their reasoning clear,
and legends split without fear—
from stacked z-heights to hyphenated delight!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'fix zindex of dialog content', but the changeset modifies z-index values across 11 UI component files, not just dialog content, including dropdown menus, tooltips, popovers, hover cards, and select menus, plus substantial changes to AI-core and Kepler components. Revise the title to reflect the broader scope, such as 'fix: update z-index layering across UI components' or 'fix: elevate z-index for overlay components and update activity UI features'.
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fix-zindex-of-dialog-content
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch fix/fix-zindex-of-dialog-content

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bdjulbic bdjulbic closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@bdjulbic @lixun910