Skip to content

feat: remove box plot - #582

Closed
dmitriy-kostianetskiy wants to merge 8 commits into
mainfrom
feat/remove-box-plot
Closed

dmitriy-kostianetskiy wants to merge 8 commits into
mainfrom
feat/remove-box-plot

Conversation

@dmitriy-kostianetskiy

Copy link
Copy Markdown
Collaborator

Box Plot chart not supported.

dmitriy-kostianetskiy and others added 8 commits April 29, 2026 15:06
Co-authored-by: Copilot <[email protected]>
- Added `addDefaultChart` method to `MosaicDashboardContext` for default chart creation.
- Wrapped `RendererComponent` in `DashboardPanelErrorBoundary` in `MosaicDashboardPanel` for error handling.
- Updated `MosaicDashboardProfilerPanelRenderer` to use `ProfilerPanelRendererProps`.
- Refactored `createMosaicDashboardVgPlotPanelConfig` to accept `VgPlotChartConfig` directly.
- Modified `MosaicDashboardToolbar` to trigger `addDefaultChart` instead of `openBuilder`.
- Improved `ChartSettings` component structure with a new context for better state management.
- Removed deprecated chart settings components (e.g., `BoxPlotSettings`, `BubbleSettings`, etc.) and replaced them with a dynamic settings approach.
- Introduced `DynamicChartSettings` for handling chart-specific settings dynamically based on selected chart type.
- Updated `generateMosaicChartSpec` to include error handling and improved logging.
- Cleaned up imports and exports across various files for better organization and clarity.

Co-authored-by: Copilot <[email protected]>
@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0ef6ccc2-c953-421f-9785-96bd1884e9fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/remove-box-plot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from dashboard-charts-settings-1 to main May 5, 2026 12:50
@ilyabo

ilyabo commented May 6, 2026

Copy link
Copy Markdown
Collaborator

might be superseded by #588

@dmitriy-kostianetskiy

Copy link
Copy Markdown
Collaborator Author

not relevant anymore, fixed here: #588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants