Skip to content

feat: add filter related kepler.gl actions in KeplerSlice - #555

Merged
lixun910 merged 1 commit into
mainfrom
553-add-more-kepler-actions-to-keplerslice-add-filter-animation-time-and-animation-window
Apr 21, 2026
Merged

feat: add filter related kepler.gl actions in KeplerSlice#555
lixun910 merged 1 commit into
mainfrom
553-add-more-kepler-actions-to-keplerslice-add-filter-animation-time-and-animation-window

Conversation

@lixun910

@lixun910 lixun910 commented Apr 20, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator
  • addFilter: kepler.gl addFilterAction
  • setFilter: kepler.gl setFilterAction
  • setFilterAnimationTime: kepler.gl setFilterAnimationTimeAction
  • setFilterAnimationWindow: kepler.gl setFilterAnimationWindowAction

Summary by CodeRabbit

  • New Features
    • Extended filter management API with four new public methods: add filters to maps, update filter properties, control filter animation timing, and configure animation windows for enhanced programmatic filtering capabilities.

@lixun910 lixun910 linked an issue Apr 20, 2026 that may be closed by this pull request
Add more kepler actions to KeplerSlice: add filter, animation time and animation window #553
Closed
@coderabbitai

coderabbitai Bot commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dab72f76-7dab-40b2-90a3-3d0392cc320b

📥 Commits

Reviewing files that changed from the base of the PR and between b4e8097 and ffb3419.

📒 Files selected for processing (1)
  • packages/kepler/src/KeplerSlice.ts
📝 Walkthrough

Walkthrough

Extended the Kepler slice state with four new public filter management methods—addFilter, setFilter, setFilterAnimationTime, and setFilterAnimationWindow. Each method registers the target map and dispatches the corresponding Kepler action, providing a unified interface for filter operations.

Changes

Cohort / File(s) Summary
Filter Action Methods
packages/kepler/src/KeplerSlice.ts		 Added four new public methods to KeplerSliceState.kepler for filter management: addFilter, setFilter, setFilterAnimationTime, and setFilterAnimationWindow. Each method registers the map via registerKeplerMapIfNotExists() before dispatching the corresponding Kepler action. Updated imports to alias existing action creators to avoid naming conflicts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Poem

🐰 Four filters hop into the slice today,
Register, dispatch, and save the day!
Animation winds and filters flow,
A rabbit's gift to help things glow! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding filter-related kepler.gl actions to KeplerSlice, which matches the changeset accurately.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 553-add-more-kepler-actions-to-keplerslice-add-filter-animation-time-and-animation-window

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lixun910
lixun910 requested a review from ilyabo April 20, 2026 23:35
@lixun910
lixun910 merged commit ce023cc into main Apr 21, 2026
4 checks passed
@lixun910
lixun910 deleted the 553-add-more-kepler-actions-to-keplerslice-add-filter-animation-time-and-animation-window branch April 21, 2026 15:22
@coderabbitai coderabbitai Bot mentioned this pull request Apr 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyabo ilyabo ilyabo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

Add more kepler actions to KeplerSlice: add filter, animation time and animation window

2 participants

@lixun910 @ilyabo