Repository navigation
Conversation
Signed-off-by: Ilya Boyandin <[email protected]>
Signed-off-by: Ilya Boyandin <[email protected]>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemove many package/example changelogs, add/adjust formatting and lint tooling, reorder Tailwind utility class strings across UI examples/components, and perform widespread documentation and minor Python/JS formatting changes (no API or behavioral changes). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/layout/README.md (1)
90-92: Consider consistent formatting for both buttons.The second button is now formatted across multiple lines, while the first button on line 89 remains on a single line. For consistency in this documentation example, both buttons should follow the same formatting pattern.
📝 Suggested formatting for consistency
Either format both on single lines:
<div className="flex gap-2"> <Button onClick={() => togglePanel('data')}>Toggle Data Panel</Button> - <Button onClick={() => togglePanelPin('data')}> - Pin/Unpin Data Panel - </Button> + <Button onClick={() => togglePanelPin('data')}>Pin/Unpin Data Panel</Button> </div>Or format both across multiple lines:
<div className="flex gap-2"> - <Button onClick={() => togglePanel('data')}>Toggle Data Panel</Button> + <Button onClick={() => togglePanel('data')}> + Toggle Data Panel + </Button> <Button onClick={() => togglePanelPin('data')}> Pin/Unpin Data Panel </Button> </div>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/layout/README.md` around lines 90 - 92, The two example Button usages are formatted inconsistently; update the Button that calls togglePanelPin('data') and the other Button so they follow the same style (either both single-line or both multi-line) in the README example; locate the Button elements referencing togglePanelPin and the button label "Pin/Unpin Data Panel" and make their JSX formatting consistent across both occurrences..prettierignore (1)
2-2: Consider narrowing hidden-directory ignore scope.
.*\/is very broad and will skip formatting for all root dot-directories (including.github/). If that’s not intentional, list only specific directories you want ignored.✂️ Suggested change
docs/api/ -.*/ +.turbo/ +.next/ +.cache/ CHANGELOG.md🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.prettierignore at line 2, The ignore pattern ".*\/" in .prettierignore is too broad and skips all root dot-directories; replace it with an explicit list of the dot-directories you actually want ignored (e.g., ".git/", ".github/", ".venv/", ".cache/") or remove the pattern entirely if you only intended specific entries, ensuring the pattern ".*\/" is updated to the exact directory names to avoid unintentionally skipping formatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@python/sqlrooms-rag/docs/METADATA.md`:
- Around line 205-210: The fenced code block in METADATA.md lacks a language tag
(triggering markdownlint MD040); update the block that begins with triple
backticks containing "Created database with: text-embedding-3-small..." to
include a language identifier (e.g., add "text" after the opening ```), so
change ``` to ```text to satisfy the linter.
---
Nitpick comments:
In @.prettierignore:
- Line 2: The ignore pattern ".*\/" in .prettierignore is too broad and skips
all root dot-directories; replace it with an explicit list of the
dot-directories you actually want ignored (e.g., ".git/", ".github/", ".venv/",
".cache/") or remove the pattern entirely if you only intended specific entries,
ensuring the pattern ".*\/" is updated to the exact directory names to avoid
unintentionally skipping formatting.
In `@packages/layout/README.md`:
- Around line 90-92: The two example Button usages are formatted inconsistently;
update the Button that calls togglePanelPin('data') and the other Button so they
follow the same style (either both single-line or both multi-line) in the README
example; locate the Button elements referencing togglePanelPin and the button
label "Pin/Unpin Data Panel" and make their JSX formatting consistent across
both occurrences.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: aa69373e-f2f4-402a-85f5-e66ca7d8d1bd
⛔ Files ignored due to path filters (1)
python/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (115)
.gitignore.lintstagedrc.json.prettierignoreAGENTS.mdcontributing/architecture.mdcontributing/patterns.mdcontributing/python.mddocs/commands.mddocs/deployment-scenarios.mddocs/upgrade-guide.mddocs/whats-new.mdexamples/ai-agent/CHANGELOG.mdexamples/ai-core/CHANGELOG.mdexamples/ai-rag/CHANGELOG.mdexamples/ai/CHANGELOG.mdexamples/app-builder/CHANGELOG.mdexamples/canvas-sync/src/InputApiKey.tsxexamples/cosmos-embedding/src/components/publications-map/components/Legend.tsxexamples/deckgl-discuss/src/components/DiscussionPanel.tsxexamples/deckgl-mosaic/src/components/map/MapControls.tsxexamples/deckgl-mosaic/src/components/map/MapView.tsxexamples/deckgl/src/components/MainView.tsxexamples/get-started/src/components/MainView.tsxexamples/kepler/CHANGELOG.mdexamples/kepler/src/components/KeplerMapsContainer.tsxexamples/mosaic/CHANGELOG.mdexamples/mosaic/src/components/MainView.tsxexamples/query-pwa/src/MainView.tsxexamples/query-websocket/src/MainView.tsxexamples/query/src/MainView.tsxexamples/sync/README.mdpackage.jsonpackages/ai-config/CHANGELOG.mdpackages/ai-core/CHANGELOG.mdpackages/ai-core/README.mdpackages/ai-rag/CHANGELOG.mdpackages/ai-settings/CHANGELOG.mdpackages/ai-settings/README.mdpackages/ai-settings/src/components/AiSettingsPanel.tsxpackages/ai/CHANGELOG.mdpackages/ai/README.mdpackages/canvas/CHANGELOG.mdpackages/cells/CHANGELOG.mdpackages/codemirror/CHANGELOG.mdpackages/cosmos/CHANGELOG.mdpackages/cosmos/README.mdpackages/cosmos/src/CosmosGraphControls.tsxpackages/crdt/CHANGELOG.mdpackages/crdt/README.mdpackages/data-table/CHANGELOG.mdpackages/db/CHANGELOG.mdpackages/discuss/CHANGELOG.mdpackages/discuss/README.mdpackages/discuss/src/components/CommentItem.tsxpackages/dropzone/CHANGELOG.mdpackages/duckdb-core/CHANGELOG.mdpackages/duckdb-node/CHANGELOG.mdpackages/duckdb/CHANGELOG.mdpackages/duckdb/__tests__/DuckDbSlice.test.tspackages/kepler-config/CHANGELOG.mdpackages/kepler/CHANGELOG.mdpackages/layout-config/CHANGELOG.mdpackages/layout/CHANGELOG.mdpackages/layout/README.mdpackages/monaco-editor/CHANGELOG.mdpackages/monaco-editor/README.mdpackages/mosaic/CHANGELOG.mdpackages/motherduck/CHANGELOG.mdpackages/notebook/CHANGELOG.mdpackages/preset-eslint/CHANGELOG.mdpackages/preset-jest/CHANGELOG.mdpackages/preset-typedoc/CHANGELOG.mdpackages/preset-typescript/CHANGELOG.mdpackages/recharts/CHANGELOG.mdpackages/room-config/CHANGELOG.mdpackages/room-shell/CHANGELOG.mdpackages/room-shell/src/data-sources/TableCard.tsxpackages/room-store/CHANGELOG.mdpackages/s3-browser-config/CHANGELOG.mdpackages/s3-browser/CHANGELOG.mdpackages/s3-utils/CHANGELOG.mdpackages/schema-tree/CHANGELOG.mdpackages/schema-tree/README.mdpackages/sql-editor-config/CHANGELOG.mdpackages/sql-editor/CHANGELOG.mdpackages/sql-editor/README.mdpackages/ui/CHANGELOG.mdpackages/ui/src/components/alert.tsxpackages/ui/src/components/card.tsxpackages/ui/src/components/progress.tsxpackages/utils/CHANGELOG.mdpackages/utils/README.mdpackages/vega/CHANGELOG.mdpackages/vega/src/VegaChartActions.tsxpackages/vega/src/VegaLiteSqlChart.tsxpackages/webcontainer/CHANGELOG.mdpackages/webcontainer/README.mdpython/README.mdpython/sqlrooms-cli/sqlrooms/cli.pypython/sqlrooms-cli/sqlrooms/web/db_bridge/connectors/postgres.pypython/sqlrooms-cli/sqlrooms/web/db_bridge/connectors/snowflake.pypython/sqlrooms-cli/sqlrooms/web/launcher.pypython/sqlrooms-cli/sqlrooms/web/ui.pypython/sqlrooms-cli/tests/test_cli.pypython/sqlrooms-cli/tests/test_db_bridge.pypython/sqlrooms-cli/tests/test_launcher.pypython/sqlrooms-cli/tests/test_ui_provider.pypython/sqlrooms-rag/docs/ARCHITECTURE.mdpython/sqlrooms-rag/docs/HEADER_WEIGHTING.mdpython/sqlrooms-rag/docs/METADATA.mdpython/sqlrooms-rag/docs/QUERYING.mdpython/sqlrooms-rag/pyproject.tomlpython/sqlrooms-server/sqlrooms/server/db_async.pypython/sqlrooms-server/sqlrooms/server/query.pypython/sqlrooms-server/sqlrooms/server/tests/test_concurrency.py
💤 Files with no reviewable changes (56)
- examples/ai/CHANGELOG.md
- examples/app-builder/CHANGELOG.md
- packages/cells/CHANGELOG.md
- examples/ai-agent/CHANGELOG.md
- examples/sync/README.md
- python/sqlrooms-cli/sqlrooms/web/db_bridge/connectors/snowflake.py
- examples/ai-core/CHANGELOG.md
- examples/ai-rag/CHANGELOG.md
- examples/kepler/CHANGELOG.md
- docs/deployment-scenarios.md
- python/sqlrooms-rag/pyproject.toml
- packages/discuss/CHANGELOG.md
- python/README.md
- examples/mosaic/CHANGELOG.md
- packages/duckdb-node/CHANGELOG.md
- python/sqlrooms-cli/sqlrooms/web/ui.py
- packages/db/CHANGELOG.md
- packages/notebook/CHANGELOG.md
- packages/canvas/CHANGELOG.md
- packages/mosaic/CHANGELOG.md
- packages/data-table/CHANGELOG.md
- packages/ai/CHANGELOG.md
- packages/schema-tree/CHANGELOG.md
- packages/motherduck/CHANGELOG.md
- packages/duckdb/CHANGELOG.md
- packages/ai-rag/CHANGELOG.md
- packages/crdt/CHANGELOG.md
- packages/sql-editor/CHANGELOG.md
- packages/layout/CHANGELOG.md
- packages/kepler-config/CHANGELOG.md
- packages/layout-config/CHANGELOG.md
- packages/preset-jest/CHANGELOG.md
- packages/utils/CHANGELOG.md
- packages/codemirror/CHANGELOG.md
- packages/s3-utils/CHANGELOG.md
- packages/preset-eslint/CHANGELOG.md
- packages/ai-core/CHANGELOG.md
- packages/room-config/CHANGELOG.md
- packages/duckdb-core/CHANGELOG.md
- packages/room-store/CHANGELOG.md
- packages/preset-typedoc/CHANGELOG.md
- packages/webcontainer/CHANGELOG.md
- packages/ai-config/CHANGELOG.md
- packages/room-shell/CHANGELOG.md
- packages/dropzone/CHANGELOG.md
- packages/sql-editor-config/CHANGELOG.md
- packages/monaco-editor/CHANGELOG.md
- packages/ui/CHANGELOG.md
- packages/vega/CHANGELOG.md
- packages/kepler/CHANGELOG.md
- packages/preset-typescript/CHANGELOG.md
- packages/s3-browser-config/CHANGELOG.md
- packages/recharts/CHANGELOG.md
- packages/ai-settings/CHANGELOG.md
- packages/s3-browser/CHANGELOG.md
- packages/cosmos/CHANGELOG.md
Signed-off-by: Ilya Boyandin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Documentation
Chores