Repository navigation
fix(data-table): use Number.isFinite instead of global isFinite - #482
Merged
dmitriy-kostianetskiy merged 2 commits intoMar 18, 2026
Merged
Conversation
Co-authored-by: dmitriy-kostianetskiy <[email protected]>
dmitriy-kostianetskiy
marked this pull request as ready for review
March 18, 2026 11:24
dmitriy-kostianetskiy
merged commit Mar 18, 2026
7085ae2
into
fix/notebook-pagination
1 of 2 checks passed
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on notebook pagination styling fix
fix(data-table): use Number.isFinite instead of global isFinite
Mar 18, 2026
Copilot stopped work on behalf of
dmitriy-kostianetskiy due to an error
March 18, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataTablePaginatedFooterinconsistently used the globalisFinite()in the row count render condition (line 140) while using the stricterNumber.isFinite()elsewhere (line 37). The global variant coerces its argument before checking, e.g.isFinite("123") === true.Change
isFinite(numRows)→Number.isFinite(numRows)on line 140 for consistency and correct type narrowing behavior.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.