Repository navigation
feat: move __sqlrooms_* filtering from schemaTree to DuckDbSlice - #481
Merged
dmitriy-kostianetskiy merged 3 commits intoMar 18, 2026
Merged
Conversation
- Remove isInternalSqlRoomsResource and filtering from createDbSchemaTrees - Add defaultLoadTableSchemasFilter to DuckDbSlice that excludes __sqlrooms_* databases/schemas - Add loadTableSchemasFilter prop to CreateDuckDbSliceProps (defaults to defaultLoadTableSchemasFilter) - Apply filter in refreshTableSchemas after loadTableSchemas() - Export defaultLoadTableSchemasFilter from package index - Update tests: remove schema-tree filtering tests, add unit tests for defaultLoadTableSchemasFilter
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [437] Implement internal resource filtering in createDbSchemaTrees
feat: move __sqlrooms_* filtering from schemaTree to DuckDbSlice
Mar 18, 2026
dmitriy-kostianetskiy
marked this pull request as ready for review
March 18, 2026 13:26
dmitriy-kostianetskiy
approved these changes
Mar 18, 2026
dmitriy-kostianetskiy
merged commit Mar 18, 2026
1120d91
into
feat/filter-out-internal-assets
2 checks passed
dmitriy-kostianetskiy
added a commit
that referenced
this pull request
Mar 20, 2026
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Dmitriy Kostianetskiy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal
__sqlrooms_*resources were being filtered increateDbSchemaTrees(presentation layer). This moves the filtering upstream toDuckDbSlice, where it belongs — at data loading time.Changes
DuckDbSlice: AddeddefaultLoadTableSchemasFilter(excludes databases/schemas prefixed with__sqlrooms_) and aloadTableSchemasFilter?: (table: QualifiedTableName) => booleanprop toCreateDuckDbSliceProps. Filter is applied inrefreshTableSchemasafterloadTableSchemas().schemaTree.ts: RemovedisInternalSqlRoomsResourceand all filtering logic fromcreateDbSchemaTrees.defaultLoadTableSchemasFilterexported from@sqlrooms/duckdb.defaultLoadTableSchemasFilter.Usage
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.