Repository navigation
fix: address CodeRabbit review comments on SQL cell improvements - #472
Merged
dmitriy-kostianetskiy merged 2 commits intoMar 17, 2026
Merged
Conversation
Co-authored-by: dmitriy-kostianetskiy <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add SQL cell improvements with modular UI
fix: address CodeRabbit review comments on SQL cell improvements
Mar 16, 2026
dmitriy-kostianetskiy
marked this pull request as ready for review
March 17, 2026 11:31
dmitriy-kostianetskiy
approved these changes
Mar 17, 2026
dmitriy-kostianetskiy
merged commit Mar 17, 2026
f25e04d
into
feat/sql-cell-improvements
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues flagged in code review on the SQL cell improvements PR.
Changes
CollapsibleSectionButton: Addedgroup-focus-within:opacity-100 focus-visible:opacity-100so the collapse toggle is visible when keyboard-focused (was hover-only), andaria-expanded={!isCollapsed}for screen reader state.SqlCellResults: AddedresultNameto the paginationuseEffectdependency array — without it, renaming a cell while viewing results would leave stale data since the effect wouldn't re-run. Removed the now-unnecessaryeslint-disablecomment.CodeMirrorEditor: Revertedh-auto→h-fullon the editor mount node to prevent height collapse in full-height/absolute-positioned layouts (e.g.VegaSqlEditorPanel).🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.