Repository navigation
feat: text/markdown cell improvements - #455
Conversation
…y controls, remove border/bg when not focused Co-authored-by: dmitriy-kostianetskiy <[email protected]>
|
@copilot if text cell is in focus let's also show remove and reorder icons. add the changes to this PR |
|
@dmitriy-kostianetskiy The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@copilot if text cell is in focus let's also show remove and reorder icons. add the changes to this PR |
Co-authored-by: dmitriy-kostianetskiy <[email protected]>
Done—delete/reorder icons now stay visible whenever a text cell is focused (not just on hover). Change in commit 9cfa621. Screenshot: https://github.com/user-attachments/assets/1b9d6ee5-2202-4338-a44d-9e0c5dd0d162 |
dmitriy-kostianetskiy
changed the title
| children?: React.ReactNode; | ||
| className?: string; | ||
| }> = ({id, header, footer, children, className}) => { | ||
| hideHeader?: boolean; |
There was a problem hiding this comment.
I'd add showHeader instead and default to true
There was a problem hiding this comment.
@copilot fix this. add changes to this PR
There was a problem hiding this comment.
Renamed the prop to showHeader (default true) and updated text cells to pass showHeader: false. Change in commit 11bcd47. Screenshot: https://github.com/user-attachments/assets/1b9d6ee5-2202-4338-a44d-9e0c5dd0d162
ilyabo
left a comment
ilyabo
left a comment
There was a problem hiding this comment.
lgtm, aside from hideHeader => showHeader (we use this in several other places)
Co-authored-by: dmitriy-kostianetskiy <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: dmitriy-kostianetskiy <[email protected]> Co-authored-by: Dmitriy Kostianetskiy <[email protected]>
This pull request introduces improvements to cell rendering and editing behavior in the notebook and cells packages. The main changes add support for optionally hiding cell headers (now via a
showHeaderflag), streamline the editing UX for text cells, and update ESLint configurations for better TypeScript support.Cell rendering and header customization:
showHeaderprop (defaulttrue) to theCellContainercomponents in bothnotebookandcellspackages, allowing cells to be rendered without a header. WhenshowHeaderisfalse, cell controls (delete, move) are shown in a floating toolbar that remains visible while the cell is focused. (packages/notebook/src/cells/CellContainer.tsx,packages/cells/src/types.ts, [1] [2] [3] [4]CellViewand cell registry rendering logic to pass the newshowHeaderprop, enabling flexible cell layouts. (packages/notebook/src/cells/CellView.tsx, packages/notebook/src/cells/CellView.tsxL17-R23)Text cell editing UX improvements:
TextCellContent, switching to a double-click-to-edit model. Editing is now triggered by double-click, and changes are saved on blur or with the Escape key to cancel edits. (packages/cells/src/components/TextCellContent.tsx, [1] [2])ESLint configuration updates:
cellsandnotebookpackages to export an array of configs, setting thetsconfigRootDirfor improved TypeScript parsing and compatibility. (packages/cells/eslint.config.js,packages/notebook/eslint.config.js, packages/cells/eslint.config.jsL3-R13)These changes collectively improve cell customization and editing workflows, and ensure proper linting support for TypeScript projects.
DEMO:
Screen.Recording.2026-03-12.at.09.32.11.mov
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.