feat: CLI: Dynamic connector load - #407

apps/sqlrooms-cli-ui/src/components/ConnectorDriversDialog.tsx (1)

11-15: Use selector-based store access instead of direct runtimeConfig import.

At Line [11], this component reads config outside Zustand selector patterns, which can bypass reactive updates and guideline-required access patterns. Please source diagnostics via a selector/custom hook, then derive missingConnectors from that selected slice.

As per coding guidelines, **/*.{ts,tsx}: “Use Zustand selectors with memoization to avoid unnecessary re-renders …” and “Use custom Zustand selectors for accessing DuckDB store state … rather than direct connector access”.

Also applies to: 72-78

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/sqlrooms-cli-ui/src/components/ConnectorDriversDialog.tsx` around lines
11 - 15, This component directly imports runtimeConfig and computes
ConnectorDiagnostic/missingConnectors from it, bypassing Zustand selector
patterns; replace direct runtimeConfig usage by creating/using a Zustand
selector or custom hook (e.g., useRuntimeConfig or a selector like
selectDbDiagnostics) to read the diagnostics slice reactively, then compute
missingConnectors from that selected diagnostics value inside
ConnectorDriversDialog (also update the logic around the existing
missingConnectors usage at the section referenced around lines 72-78) so the
component uses memoized selector access and re-renders correctly; reference
runtimeConfig, ConnectorDiagnostic, and missingConnectors when locating the code
to change.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

python/sqlrooms-cli/sqlrooms/web/db_bridge/connectors/snowflake.py (1)

73-116: Consider extracting shared install commands to reduce duplication.

The installCommands dict is duplicated between the exception handler (lines 85-96) and the unavailable case (lines 104-115). Consider extracting this to a constant or helper.

♻️ Optional refactor to reduce duplication

+_SNOWFLAKE_UNAVAILABLE_DIAGNOSTICS = {
+    "available": False,
+    "error": "Missing Python dependency: snowflake-connector-python",
+    "requiredPackages": ["snowflake-connector-python>=4.3.0"],
+    "installCommands": {
+        "uvProject": "uv sync --extra snowflake",
+        "uvxRelaunch": (
+            'uvx --from "sqlrooms-cli[snowflake]" sqlrooms '
+            "--db-path :memory:"
+        ),
+        "uvxWith": (
+            'uvx --from sqlrooms-cli --with '
+            '"snowflake-connector-python>=4.3.0" '
+            "sqlrooms --db-path :memory:"
+        ),
+    },
+}
+
 def dependency_diagnostics(self) -> dict[str, Any]:
     try:
         available = importlib.util.find_spec("snowflake.connector") is not None
     except ModuleNotFoundError as exc:
-        return {
-            "available": False,
-            "reason": (
+        return {
+            **_SNOWFLAKE_UNAVAILABLE_DIAGNOSTICS,
+            "reason": (
                 f"Failed to inspect dependency via "
                 f"find_spec('snowflake.connector'): {exc}"
             ),
-            "error": "Missing Python dependency: snowflake-connector-python",
-            ...
         }
     if available:
         return {"available": True}
-    return {
-        "available": False,
-        ...
-    }
+    return dict(_SNOWFLAKE_UNAVAILABLE_DIAGNOSTICS)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@python/sqlrooms-cli/sqlrooms/web/db_bridge/connectors/snowflake.py` around
lines 73 - 116, The duplicated installCommands dict in dependency_diagnostics
should be extracted to a single constant or helper (e.g.,
SNOWFLAKE_INSTALL_COMMANDS or get_snowflake_install_commands()) and reused in
both the ModuleNotFoundError return and the unavailable return; update
dependency_diagnostics to reference that constant/helper instead of inlining the
same dict twice and keep the other returned fields identical (available, error,
requiredPackages) while reusing the shared install commands.

apps/sqlrooms-cli-ui/src/store.ts (1)

150-155: Extract a shared diagnostics type to avoid schema drift.

Line [150] defines a second inline diagnostics shape that already exists (richer) at Line [80]. Keeping both inline increases maintenance risk.

♻️ Proposed refactor

+type ConnectorDriverDiagnostic = {
+  id: string;
+  engineId: string;
+  title: string;
+  available: boolean;
+  error?: string;
+  reason?: string;
+  requiredPackages?: string[];
+  installCommands?: {
+    uvProject?: string;
+    uvxRelaunch?: string;
+    uvxWith?: string;
+  };
+};

 export type RoomState = RoomShellSliceState &
   AiSliceState &
   SqlEditorSliceState &
   AiSettingsSliceState &
   CellsSliceState &
   NotebookSliceState &
   CanvasSliceState &
   WebContainerSliceState & {
-    connectorDriverDiagnostics: Array<{
-      id: string;
-      engineId: string;
-      title: string;
-      available: boolean;
-      error?: string;
-      reason?: string;
-      requiredPackages?: string[];
-      installCommands?: {
-        uvProject?: string;
-        uvxRelaunch?: string;
-        uvxWith?: string;
-      };
-    }>;
+    connectorDriverDiagnostics: ConnectorDriverDiagnostic[];
 ...
 function getRuntimeBridgeConfig():
   | {
       id: string;
       connections: Array<{
         id: string;
         engineId: string;
         title: string;
         runtimeSupport?: 'browser' | 'server' | 'both';
         requiresBridge?: boolean;
         bridgeId?: string;
         isCore?: boolean;
       }>;
-      diagnostics?: Array<{
-        id: string;
-        engineId: string;
-        title: string;
-        available: boolean;
-      }>;
+      diagnostics?: ConnectorDriverDiagnostic[];
     }
   | undefined {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/sqlrooms-cli-ui/src/store.ts` around lines 150 - 155, Replace the
duplicated inline diagnostics shape with the shared diagnostics type already
declared earlier in this file: remove the inline definition under the
diagnostics? property and reference the existing richer Diagnostics type (or the
exact exported/interface name used above) so both places use the same type;
update the diagnostics?: Array<...> usage to diagnostics?: Diagnostics[] (or the
exact identifier) and remove the redundant inline shape to prevent schema drift.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

apps/sqlrooms-cli-ui/src/components/ConnectorDriversDialog.tsx (1)

146-150: Consider pluralizing "Required package" when there are multiple packages.

The label says "Required package:" but requiredPackages is an array that could contain multiple items.

📝 Suggested fix

               {!diagnostic.available && diagnostic.requiredPackages?.length ? (
                 <div className="mt-2 text-xs">
-                  Required package:{' '}
+                  Required package{diagnostic.requiredPackages.length > 1 ? 's' : ''}:{' '}
                   <code>{diagnostic.requiredPackages.join(', ')}</code>
                 </div>
               ) : null}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/sqlrooms-cli-ui/src/components/ConnectorDriversDialog.tsx` around lines
146 - 150, The label "Required package:" should be pluralized when
diagnostic.requiredPackages contains more than one item; update the JSX in
ConnectorDriversDialog (the block rendering {!diagnostic.available &&
diagnostic.requiredPackages?.length}) to choose between "Required package:" and
"Required packages:" based on diagnostic.requiredPackages.length (e.g.,
conditional string or ternary) while keeping the existing
<code>{diagnostic.requiredPackages.join(', ')}</code> output.

Configuration used: defaults

Review profile: CHILL

Plan: Pro