Skip to content

chore: Lint warnings cleanup - #386

Merged
ilyabo merged 4 commits into
mainfrom
cursor/lint-warnings-cleanup-fc56
Feb 25, 2026
Merged

chore: Lint warnings cleanup#386
ilyabo merged 4 commits into
mainfrom
cursor/lint-warnings-cleanup-fc56

Conversation

@ilyabo

@ilyabo ilyabo commented Feb 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Clean up lint warnings by adjusting shared ESLint preset rules and fixing specific code issues.

A large number of warnings stemmed from overly strict shared ESLint rules (no-unused-vars, @typescript-eslint/no-unused-vars, @typescript-eslint/no-explicit-any) which have been disabled in the shared preset. Remaining actionable warnings, such as react-hooks/exhaustive-deps and stale eslint-disable comments, were addressed directly in the code.

Open in Web Open in Cursor 

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Improved S3 credentials loading to refresh when the credentials loader is updated.

  • Style

    • Updated styling for editable text input, including disabled state appearance and focus behavior.

  • Chores

    • Removed unnecessary linting directives across components.
    • Refactored internal code organization for improved maintainability.
    • Added environment configuration for build pipeline optimization.

@cursor

cursor Bot commented Feb 25, 2026

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@ilyabo ilyabo changed the title Lint warnings cleanup chore: Lint warnings cleanup Feb 25, 2026
@coderabbitai

coderabbitai Bot commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ebbb4e and ca8ee46.

📒 Files selected for processing (14)
  • packages/canvas/src/CanvasSlice.ts
  • packages/canvas/src/dag.ts
  • packages/data-table/src/DataTablePaginated.tsx
  • packages/data-table/src/DataTableVirtualized.tsx
  • packages/duckdb-core/src/load/load.ts
  • packages/kepler/src/components/CustomInteractionManager.tsx
  • packages/preset-eslint/base.js
  • packages/s3-browser/src/S3CredentialsForm.tsx
  • packages/sql-editor/src/components/RenameSqlQueryModal.tsx
  • packages/ui/src/components/editable-text.tsx
  • packages/ui/src/components/scrollable-row.tsx
  • packages/utils/src/memoization.ts
  • packages/vega/src/editor/VegaMonacoEditor.tsx
  • turbo.json
📝 Walkthrough

Walkthrough

The PR removes ESLint disable comments across multiple packages, disables three lint rules in the ESLint configuration, introduces component memoization, updates React hook dependencies, refactors code formatting and CSS class ordering, and adds NODE_ENV to Turbo's global environment variables.

Changes

Cohort / File(s) Summary
ESLint Configuration & Lint Suppressions
packages/preset-eslint/base.js, packages/canvas/src/..., packages/data-table/src/DataTablePaginated.tsx, packages/duckdb-core/src/load/load.ts, packages/sql-editor/src/components/RenameSqlQueryModal.tsx, packages/vega/src/editor/VegaMonacoEditor.tsx		 Disabled three ESLint rules in config (no-explicit-any, no-unused-vars, @typescript-eslint/no-unused-vars changed from 'warn' to 'off'); removed lint suppression comments from multiple files.
Component Memoization & Optimization
packages/kepler/src/components/CustomInteractionManager.tsx, packages/ui/src/components/scrollable-row.tsx		 Added useMemo for interactionConfig memoization; refactored updateScrollState into useEffect hook for improved lifecycle management.
Hook Dependencies & Styling
packages/s3-browser/src/S3CredentialsForm.tsx, packages/data-table/src/DataTableVirtualized.tsx, packages/ui/src/components/editable-text.tsx		 Updated useEffect dependency arrays; reordered Tailwind CSS classes in table and input elements; added disabled:opacity-1 styling and selectOnFocus dependency.
Utility & Code Refactoring
packages/utils/src/memoization.ts, packages/data-table/src/DataTablePaginated.tsx		 Simplified function call formatting in memoizeOnce; added explanatory comments for TanStack hook non-memoizable behavior.
Build Configuration
turbo.json		 Added NODE_ENV to globalEnv to propagate environment variable to Turbo tasks.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 With lint rules silenced and memos in place,
Hooks dance through dependencies with newfound grace,
Turbo now knows the NODE_ENV way,
A code cleanup quest ends bright as day! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/lint-warnings-cleanup-fc56

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ilyabo
ilyabo marked this pull request as ready for review February 25, 2026 10:08
@ilyabo
ilyabo merged commit eebd32c into main Feb 25, 2026
3 checks passed
@ilyabo
ilyabo deleted the cursor/lint-warnings-cleanup-fc56 branch February 25, 2026 10:09
This was referenced Mar 11, 2026
Merged
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Apr 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@ilyabo @cursoragent