Repository navigation
chore: DuckDB wasm upgrade - #366
Conversation
Co-authored-by: Ilya Boyandin <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughMultiple package.json files were updated to change Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
examples/query-pwa/package.json (1)
15-15: Pre-existing:@sqlrooms/dropzoneshould useworkspace:*.
@sqlrooms/dropzoneis listed as"^0.16.4"instead of"workspace:*". This predates this PR but violates the monorepo convention. Consider fixing in a follow-up. As per coding guidelines, "Ensure all package.json dependencies use the workspace protocol (workspace:*) for monorepo internal packages."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@examples/query-pwa/package.json` at line 15, The dependency entry for the internal package `@sqlrooms/dropzone` is using a published semver ("^0.16.4") instead of the monorepo workspace protocol; update the dependency key for "@sqlrooms/dropzone" in the package.json to use "workspace:*" so it follows the monorepo convention (then run your package manager to refresh lockfiles/install if needed).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@examples/query-pwa/package.json`:
- Line 15: The dependency entry for the internal package `@sqlrooms/dropzone` is
using a published semver ("^0.16.4") instead of the monorepo workspace protocol;
update the dependency key for "@sqlrooms/dropzone" in the package.json to use
"workspace:*" so it follows the monorepo convention (then run your package
manager to refresh lockfiles/install if needed).
Signed-off-by: Ilya Boyandin <[email protected]>
Signed-off-by: Ilya Boyandin <[email protected]>
Upgrade
@duckdb/duckdb-wasmto the latest stable version1.32.0.This ensures all packages and examples in the monorepo use a consistent and up-to-date DuckDB WASM build, resolving previous mixed versions.
Summary by CodeRabbit