fix: getKeplerFactory number of hook calls errors - #354

packages/kepler/src/components/KeplerInjector.tsx (2)

165-187: ⚠️ Potential issue | 🟠 Major

Wrapped is recreated on every call — callers inside render will trigger remounts.

The inner Component is correctly cached in the WeakMap, but getKeplerFactory returns a new Wrapped function (i.e. a new React component type) on every invocation. If a caller happens to invoke getKeplerFactory(SomeFactory) during a component's render (rather than at module scope), React will see a different component type each render and unmount/remount the subtree.

Consider also caching the Wrapped wrapper in the same byFactory map (or a parallel cache) keyed by (injector, factory), so repeated calls for the same factory return a referentially stable component.

♻️ Sketch: cache the wrapper alongside the resolved component

+const wrapperCache = new WeakMap<
+  object,
+  Map<KeplerFactory, React.ComponentType<any>>
+>();
+
 export function getKeplerFactory<TFactory extends KeplerFactory>(
   factory: TFactory,
 ): ReturnType<TFactory> {
-  const Wrapped = ((props: Record<string, unknown>) => {
+  const injectorInstance = getKeplerInjector();
+  let byFactory = wrapperCache.get(injectorInstance as object);
+  if (byFactory === undefined) {
+    byFactory = new Map();
+    wrapperCache.set(injectorInstance as object, byFactory);
+  }
+  let Wrapped = byFactory.get(factory);
+  if (Wrapped !== undefined) {
+    return Wrapped as unknown as ReturnType<TFactory>;
+  }
+  Wrapped = ((props: Record<string, unknown>) => {
     const injectorInstance = getKeplerInjector();
     let byFactory = injectorToFactoryCache.get(injectorInstance as object);
     ...
     return <Component {...props} />;
-  }) as unknown as ReturnType<TFactory>;
-  return Wrapped;
+  }) as React.ComponentType<any>;
+  byFactory.set(factory, Wrapped);
+  return Wrapped as unknown as ReturnType<TFactory>;
 }

---

189-193: ⚠️ Potential issue | 🟡 Minor

Add KeplerInjector to barrel export if intended as public API.

KeplerInjector is exported from packages/kepler/src/components/KeplerInjector.tsx but not re-exported from packages/kepler/src/index.ts. If KeplerInjector is meant to be the stable public entry point, add it to the barrel export alongside the existing re-exports (getKeplerFactory, getKeplerInjector, etc.).

Consider adding JSDoc to KeplerInjector.get() noting that it should be called at module scope or in a constant initializer (outside component render) to keep the returned component reference stable.

packages/kepler/src/components/KeplerInjector.tsx (1)

187-191: ⚠️ Potential issue | 🟡 Minor

Add KeplerInjector to the package index exports.

KeplerInjector is exported from packages/kepler/src/components/KeplerInjector.tsx but not re-exported from packages/kepler/src/index.ts. If it is intended as a public API, add it to the export list alongside the related function exports.