Skip to content

fix: Avoid deckgl v8 type errors - #351

Merged
ilyabo merged 1 commit into
mainfrom
fix--Avoid-deckgl-v8-type-errors
Feb 11, 2026
Merged

ilyabo merged 1 commit into
mainfrom
fix--Avoid-deckgl-v8-type-errors

Conversation

@ilyabo

@ilyabo ilyabo commented Feb 10, 2026 •

Copy link
Copy Markdown
Collaborator

Should prevent type errors in dev/build caused by having two versions of deck.gl in the monorepo

Summary by CodeRabbit

  • Chores
    • Enhanced TypeScript module resolution configuration with path aliasing support.

@coderabbitai

coderabbitai Bot commented Feb 10, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The pull request adds TypeScript module resolution configuration to packages/kepler/tsconfig.json, introducing baseUrl and paths mapping to enable aliasing for @deck.gl/core/src/* modules. The existing outDir setting is retained with minor syntax adjustments.

Changes

Cohort / File(s) Summary
TypeScript Configuration
packages/kepler/tsconfig.json
Added baseUrl and paths mapping in compilerOptions to enable @deck.gl/core/src/* module aliasing with relative path resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A path declared, an alias born,
TypeScript's routes now reformed,
No runtime fears, just mapping neat,
Module resolution, fast and sweet!
baseUrl hops, the config's done,
Type-checking happiness for everyone! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: Avoid deckgl v8 type errors' directly relates to the main change—updating TypeScript configuration to resolve type resolution issues with deck.gl v8 dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix--Avoid-deckgl-v8-type-errors

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
packages/kepler/tsconfig.json (1)

6-12: Fragile multi-level node_modules paths — consider a comment explaining the rationale.

The triple relative-path fallback (../../, ../../../, ../../../../) is a pragmatic workaround for monorepo hoisting uncertainty, but it's brittle — if nesting depth changes or the package manager's hoisting strategy shifts, resolution will silently fail. Consider adding a brief comment in this file (or linking the relevant deck.gl issue) so future maintainers understand why these paths exist and when they can be removed (e.g., after upgrading to deck.gl v9).

Also, if only one of these paths is actually needed in your current setup, trimming the others would reduce confusion.

#!/bin/bash
# Check which node_modules path actually contains `@deck.gl/core/typed`
fd -t d "typed" --full-path "@deck.gl/core" -E dist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ilyabo
ilyabo merged commit b3d5b88 into main Feb 11, 2026
5 checks passed
@ilyabo
ilyabo deleted the fix--Avoid-deckgl-v8-type-errors branch February 11, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant