Fix Android N preview for API 23 (build)#231
Merged
developernotes merged 1 commit intosqlcipher:android-n-previewfrom May 10, 2016
Merged
Fix Android N preview for API 23 (build)#231developernotes merged 1 commit intosqlcipher:android-n-previewfrom
developernotes merged 1 commit intosqlcipher:android-n-previewfrom
Conversation
This was referenced May 4, 2016
Member
|
Hi @brodybits Thanks for this, we've just merged this change in! |
Author
|
Thank you!)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change properly supports AbstractCursor.setExtras/AbstractCursor.getExtras according to API 23 and was taken from the AOSP (with the "@OverRide" attribute omitted). It would allow people to build on API 23.
In addition to fixing the build on API 23, this change fixes a remote possibility that someone passes a SQLiteCursor, MatrixCursor, or BulkCursorToCursorAdaptor to an external library function that takes a Cursor and calls setExtras on that Cursor. While I expect the changes of this happening to be very low, it is a side effect of a build problem that can easily be fixed by the change proposed here.
Thanks in advance for your consideration.