Fix Android N preview build on API 23#230
Closed
brody4hire wants to merge 2 commits intosqlcipher:android-n-previewfrom
Closed
Fix Android N preview build on API 23#230brody4hire wants to merge 2 commits intosqlcipher:android-n-previewfrom
brody4hire wants to merge 2 commits intosqlcipher:android-n-previewfrom
Conversation
added 2 commits
May 3, 2016 17:37
Member
|
Hi @brodybits Thanks for submitting a pull request. What benefit do we have moving from API 19 to API 23? It appears the only other code change is a stubbed method to allow for compilation that throws an exception. |
Author
|
Closing in favor of #231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I completely understand the desire to support execution on older Android versions, I find it strange that we cannot build this project on the new Android SDK as discussed in: https://discuss.zetetic.net/t/android-build-faile/1319
The only fix needed to build on SDK 23 is to define a bogus AbstractCursor.setExtras(Bundle) method.
An alternative would be to implement a working setExtras(Bundle) method for the AbstractCursor/AbstractWindowedCursor subclass(es).