Complete dynamic index querying for DuckDB (#1163)#1294
Open
Elshaarawy-1 wants to merge 2 commits intosqlancer:mainfrom
Open
Complete dynamic index querying for DuckDB (#1163)#1294Elshaarawy-1 wants to merge 2 commits intosqlancer:mainfrom
Elshaarawy-1 wants to merge 2 commits intosqlancer:mainfrom
Conversation
Based on PR sqlancer#1171 Addresses sqlancer#1163
Remove DATABASE_NAME filter to fix index collision bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PR #1171 by @ahmed-kamal2004 implemented
getIndexes()but had a bug where it filtered bySQLancer's database name (
"duckdb0") instead of DuckDB's actual name(
"memory"in in-memory mode). This caused empty results and index namecollisions.
Changes
Commit 1: Adopted initial implementation from PR #1171
DuckDBSchema.getIndexes()duckdb_indexes()system tableCommit 2: Fixed the bug
DATABASE_NAMEfilter (SQLancer tests single database)Testing
Ran SQLancer with DuckDB - index names now properly tracked.
Fixes #1163