Fix #1249: Correct REINDEX INDEX syntax to use single index instead of concatenating all#1283
Open
guptapratykshh wants to merge 1 commit intosqlancer:mainfrom
Open
Fix #1249: Correct REINDEX INDEX syntax to use single index instead of concatenating all#1283guptapratykshh wants to merge 1 commit intosqlancer:mainfrom
guptapratykshh wants to merge 1 commit intosqlancer:mainfrom
Conversation
…nstead of concatenating all
Author
|
ping @robins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1249
This PR fixes an issue where
PostgresReindexGeneratorwas incorrectly concatenating all index names without delimiters, generating invalid SQL likeREINDEX INDEX i1i2i3. PostgreSQL only supports one index per REINDEX INDEX statement, so the fix now randomly selects a single index usingRandomly.fromList(indexes).getIndexName()instead of joining all indexes together.