Add Support for Merge Generator in Postgres v15#1255
Open
yaojiejia wants to merge 3 commits intosqlancer:mainfrom
Open
Add Support for Merge Generator in Postgres v15#1255yaojiejia wants to merge 3 commits intosqlancer:mainfrom
yaojiejia wants to merge 3 commits intosqlancer:mainfrom
Conversation
mrigger
reviewed
Jul 6, 2025
mrigger
reviewed
Jul 28, 2025
|
|
||
| PostgresColumn column = columns.get(i); | ||
|
|
||
| if (Randomly.getBoolean() && sourceHasColumn(column, sourceTable)) { |
Contributor
There was a problem hiding this comment.
There are a couple of repeated code patterns here. It would be great to factor them out to methods.
mrigger
reviewed
Aug 25, 2025
| } else { | ||
| sb.append(generateUpdateSet(targetTable, sourceTable)); | ||
| } | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
This looks a bit surprising. Why does throwing an exception affect the logic of what we generate here? Can we achieve the intended outcome without relying on exceptions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1254