Conversation
NamedParameterUtils.parseSqlStatement threw an ArrayIndexOutOfBoundsException for an SQL statement ending with '-' or '/', since skipCommentsAndQuotes compared the second character of the "--" and "/*" comment starts without checking the statement length. This commit treats such a trailing character as not starting a comment, leaving the statement as is. Signed-off-by: Sanghyuk Jung <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NamedParameterUtils.parseSqlStatementthrows anArrayIndexOutOfBoundsExceptionwhen the SQL statement ends with-or/, for exampleselect * from t where a = :a -.skipCommentsAndQuotesmatches the first character of the--and/*comment starts and then reads the next character without checking the statement length.This PR treats such a trailing character as not starting a comment, so the statement is left as is and any syntax error is reported by the driver instead.