Skip to content

Simplify some control flow code#24907

Closed
Deycoesr wants to merge 0 commit into
spring-projects:masterfrom
Deycoesr:master
Closed

Simplify some control flow code#24907
Deycoesr wants to merge 0 commit into
spring-projects:masterfrom
Deycoesr:master

Conversation

@Deycoesr
Copy link
Copy Markdown
Contributor

I found some control flow code can be simplify

@pivotal-issuemaster
Copy link
Copy Markdown

@Deycoesr Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link
Copy Markdown

@Deycoesr Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 14, 2020
@sbrannen sbrannen self-assigned this Apr 14, 2020
@sbrannen sbrannen added the type: task A general task label Apr 14, 2020
Copy link
Copy Markdown
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I requested that you revert a few of the changes for the sake of readability.

Once you make those changes, I'll be glad to merge this PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the proposed changed is technically correct, please revert this for the sake of readability.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the proposed changed is technically correct, please revert this for the sake of readability.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the proposed changed is technically correct, please revert this for the sake of readability.

@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 17, 2020
@Deycoesr Deycoesr closed this Apr 17, 2020
@sbrannen
Copy link
Copy Markdown
Member

@Deycoesr, did you intentionally close this PR?

@Deycoesr
Copy link
Copy Markdown
Contributor Author

Not, I used git push origin HEAD --force.

@Deycoesr
Copy link
Copy Markdown
Contributor Author

I'm sorry, i don't know there will be such consequences. I created a new PR. #24925

@sbrannen sbrannen removed the status: waiting-for-feedback We need additional information before we can continue label Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants