expose backward compatible connection mgr#407
Merged
dargmuesli merged 3 commits intospotify-web-api-java:masterfrom Dec 3, 2024
bruceadowns:expose-connmgr
Merged
expose backward compatible connection mgr#407dargmuesli merged 3 commits intospotify-web-api-java:masterfrom bruceadowns:expose-connmgr
dargmuesli merged 3 commits intospotify-web-api-java:masterfrom
bruceadowns:expose-connmgr
Conversation
* add HttpClientConnectionManager to SpotifyHttpManager.builder * add getConnectionManager to handle default
dargmuesli
reviewed
Nov 28, 2024
added 2 commits
November 27, 2024 23:03
dargmuesli
reviewed
Dec 2, 2024
Member
dargmuesli
left a comment
There was a problem hiding this comment.
Thank you for the suggestion. I've built upon this PR in #409 to keep the current builder usage. Please tell me if my changes would work for you too! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #375, but providing backwards compatibility to be included in a 8.4.2.
The default usage does not change, however adding support for PoolingHttpClientConnectionManager would look like this: