Make Pythonflow thread-compatible.#40
Merged
tillahoffmann merged 1 commit intospotify:masterfrom Feb 13, 2019
Merged
Conversation
Previously it was impossible to use Pythonflow in a multithreaded application: with this patch it is possible to use distinct Pythonflow graphs, one per-thread.
| with pf.Graph() as graph: | ||
| event.set() | ||
| except AssertionError as e: | ||
| event.set() |
Collaborator
There was a problem hiding this comment.
Do we need to call event.set() here in case the test fails such that the tests don't hang?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was impossible to use
pythonflowin a multithreaded application: with this patch it is possible to use distinctpythonflowgraphs, one per-thread.