chore: support Windows in dev env - #68
Merged
Merged
Conversation
Add CLAUDE.md to .prettierignore so Prettier skips the symlink target, and enable core.symlinks in the prepare script so Windows clones checkout the symlink correctly after pnpm install. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
URL.pathname returns /C:/Users/... on Windows, breaking path alias resolution. fileURLToPath() handles this correctly cross-platform. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
/tmp/ doesn't exist on Windows. Use perPlatform() to pick os.tmpdir() on Windows while keeping /tmp/ on Unix for stable e2e snapshot column alignment. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
On Windows, scripts need a .cmd launcher instead of a Unix shebang and chmod. Split binary writing into writeUnixBinary/writeWindowsBinary in a new fs.ts module and add IS_WINDOWS to the e2e env constants. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Windows uses ; not : as the PATH separator. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Windows uses USERPROFILE/TEMP/TMP instead of HOME/TMPDIR. Set the Windows equivalents alongside the Unix vars so both are available. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
The test relies on /usr/bin as a PATH with git but not node, which has no portable Windows equivalent. Other system-check tests already validate the failure UI. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
bespoyasov
marked this pull request as ready for review
September 17, 2026 13:47
Deduplicate case-insensitive env keys, run PATH .js shims with Node instead of .cmd files, and stop mutating git config in prepare. Co-authored-by: Cursor <[email protected]>
filipmyllari
self-requested a review
September 23, 2026 15:26
filipmyllari
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #67.
Fixes Windows compatibility issues in the dev pipeline so tests can pass on Windows.
CLAUDE.mdto.prettierignore. Clone withgit clone -c core.symlinks=truesoCLAUDE.mdis a real symlink (needs Developer Mode or symlink privilege).preparedoes not change git config.fileURLToPath()in Vitest configs instead ofURL.pathnameos.tmpdir()on Windows for test temp directories.jsscripts plus.cmdfor cmd.exe). The CLI runs{name}.jswith Node viaresolveBin, becauseexecFile/spawncannot execute.cmdwithout a shell.path.delimiterfor PATH separator in e2e sessionsUSERPROFILE,TEMP,TMP) and deduplicates case-insensitive keys (PathvsPATH) withoverlayEnv/usr/bin-dependent e2e test on Windows (so far)Not included
xterm-256coloris harmless on Windows, left as-isRemaining work
__tests__/shared/project-scaffold/index.ts:22-24)__tests__/e2e/system-check-failure.e2e.ts:22-26)Test plan
pnpm qapasses (typecheck + lint + 194 tests)core.symlinks=true(or re-checkoutCLAUDE.mdafter enabling it) soCLAUDE.mdis a real symlinkpnpm test:e2epasses on Windows