Skip to content

fix log message #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mredolatti merged 1 commit into from
Oct 8, 2020
+5 −2
Merged

fix log message #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions splitio/client/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ def _sanitize_impressions_mode(mode, refresh_rate=None):
try:
mode = ImpressionsMode(mode.upper())
except (ValueError, AttributeError):
_LOGGER.warning('unrecognized impressionsMode supplied. Defaulting to OPTIMIZED')
_LOGGER.warning('You passed an invalid impressionsMode, impressionsMode should be '
'one of the following values: `debug` or `optimized`. '
'Defaulting to `optimized` mode.')
mode = ImpressionsMode.OPTIMIZED

if mode == ImpressionsMode.DEBUG:
Expand All @@ -119,7 +121,8 @@ def sanitize(apikey, config):
config['operationMode'] = _parse_operation_mode(apikey, config)
processed = DEFAULT_CONFIG.copy()
processed.update(config)
imp_mode, imp_rate = _sanitize_impressions_mode(config.get('impressionsMode'), config.get('impressionsRefreshRate'))
imp_mode, imp_rate = _sanitize_impressions_mode(config.get('impressionsMode'),
config.get('impressionsRefreshRate'))
processed['impressionsMode'] = imp_mode
processed['impressionsRefreshRate'] = imp_rate
return processed