Only package speechbrain in the wheel - #3088
Open
Kayvan-Zahiri wants to merge 1 commit into
Open
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
Since the move to pyproject (speechbrain#2946), packages.find only excluded tests, so the 1.1.0 and 1.1.1 wheels also install recipes, templates, tools and docs as top-level packages in site-packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The 1.1.0 and 1.1.1 wheels install
recipes,templates,toolsanddocsas top-level packages next tospeechbrain:So
pip install speechbrainputs atoolsand atemplatespackage in site-packages, which can shadow a user's own modules with those names. 1.0.3 shipped onlyspeechbrain. The change came with the move to pyproject in #2946:[tool.setuptools.packages.find]only excludestests, so every directory with an__init__.pygets packaged.This switches the finder to
include = ["speechbrain", "speechbrain.*"].Checked by building both ways from
develop:speechbrain/are identical, andrecipes/templates/tools/docs(387 files) are gone.top_level.txtis justspeechbrain.speechbrain/plus the metadata files).version.txtandlog-config.yamlare still included.No breaking changes for
import speechbrain. Anyone who importedrecipesortemplatesfrom site-packages was relying on the accidental install.Before submitting