Skip to content

Sb discrete ssl new - #2487

Closed
poonehmousavi wants to merge 9 commits into
speechbrain:developfrom
poonehmousavi:sb_discrete_ssl_new
Closed

Sb discrete ssl new#2487
poonehmousavi wants to merge 9 commits into
speechbrain:developfrom
poonehmousavi:sb_discrete_ssl_new

Conversation

@poonehmousavi

@poonehmousavi poonehmousavi commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Refactor SSL Discrete Tokens:

  1. bitrate scalability of semantic tokens
  2. Deduplication option
  3. subwording option
  4. aggerate discrete_hubert, discrete_wavlm and discrete_wav2vec into discrete_ssl
  5. add discrete_tokenizer to perform different post-processing on extracted tokens
  6. K-means checkpointing
  7. working with varying numbers of clusters for each layer

-->

Fixes #<issue_number>

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@poonehmousavi poonehmousavi self-assigned this Apr 2, 2024
@poonehmousavi
poonehmousavi requested a review from mravanelli April 2, 2024 17:30
@poonehmousavi
poonehmousavi marked this pull request as ready for review April 12, 2024 13:30
@mravanelli mravanelli added the enhancement New feature or request label Apr 13, 2024
@poonehmousavi

poonehmousavi commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator Author

Closed and moved to this PR.
#2509

@poonehmousavi
poonehmousavi deleted the sb_discrete_ssl_new branch July 29, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mravanelli mravanelli Awaiting requested review from mravanelli

Assignees

See More

@poonehmousavi poonehmousavi

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@poonehmousavi @mravanelli