[issue-181] add files at document-level - #288
Merged
Merged
Conversation
4 tasks
meretp
force-pushed
the
issue_181_unpackaged_files
branch
3 times, most recently
from
November 16, 2022 16:32
595f2ef to
c38fea8
Compare
meretp
changed the title
nicoweidner
reviewed
Nov 21, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the big contribution! I left a bunch of suggestions, but it looks very good overall
meretp
force-pushed
the
issue_181_unpackaged_files
branch
2 times, most recently
from
November 22, 2022 09:19
0f4d147 to
f002bd3
Compare
nicoweidner
reviewed
Nov 22, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
I found a few more things, but I think we are pretty close now!
meretp
force-pushed
the
issue_181_unpackaged_files
branch
from
November 22, 2022 15:37
cdd095c to
6a6fba6
Compare
nicoweidner
previously approved these changes
Nov 22, 2022
nicoweidner
left a comment
nicoweidner
left a comment
Collaborator
There was a problem hiding this comment.
Only some nits left, thanks for addressing everything!
added 8 commits
November 22, 2022 17:16
leads to failing test concerning rdf-files Signed-off-by: Meret Behrens <[email protected]>
…iter/parser leads to failing tests for rdf and tv files Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
meretp
force-pushed
the
issue_181_unpackaged_files
branch
from
November 22, 2022 16:23
6a6fba6 to
dfeee30
Compare
nicoweidner
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is still in progress but attempts to fix #181.
also fixes #297
Signed-off-by: Meret Behrens [email protected]