Moved the metadata into setup.cfg. - #156
Conversation
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! See my comments inline for you review.
|
@KOLANICH can you also add your DCO signoff? This was an informal requirement which was not consistently applied until now... this way I can then merge. |
|
This has been merged after a rebase. |
|
Fat fingers! |
|
@KOLANICH, do you still plan to address these change requests? @pombredanne, are these changes still up-to-date? |
I think they are... but your call to verify this. |
|
Thanks @KOLANICH for updating this! :) Removing |
|
Thanks for the update, @KOLANICH! |
|
@pombredanne, this still has a blocker from you, would you mind to revisit/lift this? :) |
That doc mentions only setuptools-specific configuration. The most of
To be honest, The rest of suggestions are implemented, thanks. |
jayvdb
left a comment
jayvdb
left a comment
There was a problem hiding this comment.
There are still many other mentions of the CLI command names inside the codebase.
pdx/cli_tools/convertor.py: ' convertor ---infile <input_file> ---outfile <output_file>.
spdx/cli_tools/convertor.py: ' convertor -f/--from <type> <input_file> -t/--to <type> <output_file>.
spdx/cli_tools/convertor.py: ' convertor -f/--from <type> <input_file> --outfile <output_file> '
spdx/cli_tools/convertor.py: ' convertor --infile <input_file> -t/--to <type> <output_file>'
spdx/cli_tools/convertor.py: raise ValueError("Given arguments for convertor are invalid.")
spdx/cli_tools/convertor.py: To use : run 'convertor -f <from_TYPE> <input file> -t <to_TYPE> <output_file>' command on terminal or use ' convertor --infile <input file name> --outfile <output file name> '
nicoweidner
left a comment
nicoweidner
left a comment
There was a problem hiding this comment.
Thanks for updating the setup scripts! I won't be able to merge until the appveyor issue is resolved, though...
@pombredanne Anything missing in your opinion? You are still set to "changes requested".
Added pyproject.toml. Renamed console_scripts because their names are too generic to have this package installed into system. Fixed the names of the commands within the docstrings. Versions are now fetched from git tags. Excluded the dirs that are not meant to go into wheels, like `examples/`. Added the things jayvdb has suggested into the metadata. Co-authored-by: John Vandenberg <[email protected]> Signed-off-by: KOLANICH <[email protected]>
Signed-off-by: KOLANICH <[email protected]>
Asked for another opinion a while ago; reviewer stated (basically) that he won't be involved in a further review process in #156 (comment)
nicoweidner
left a comment
nicoweidner
left a comment
There was a problem hiding this comment.
Thanks for rebasing again, @KOLANICH! I will go ahead and merge this before new conflicts arise
| urls = {Homepage = "https://github.com/spdx/tools-python"} | ||
| requires-python = ">=3.6" | ||
| dependencies = ["ply", "rdflib", "click", "pyyaml", "xmltodict"] | ||
| dynamic = ["version"] |
There was a problem hiding this comment.
Didn't know about this, pretty cool!
In case anyone else stumbles across this: https://pypi.org/project/setuptools-scm/, look for "Default versioning scheme"
|
Please see #362 |
5 participants
Added pyproject.toml.
Renamed console_scripts because their names are too generic to have this package installed into system.
Versions are now fetched from git tags.