Skip to content

Fixed deprecation warnings for use of Chef::ShellOut#37

Closed
eklein wants to merge 1 commit into
sous-chefs:masterfrom
eklein:master
Closed

Fixed deprecation warnings for use of Chef::ShellOut#37
eklein wants to merge 1 commit into
sous-chefs:masterfrom
eklein:master

Conversation

@eklein

@eklein eklein commented Feb 14, 2013

Copy link
Copy Markdown
Contributor

When using Chef::ShellOut with chef-client 11.x, the following warnings come up during a run:

[2013-02-14T20:28:19+00:00] WARN: Chef::ShellOut is deprecated, please use Mixlib::ShellOut
[2013-02-14T20:28:19+00:00] WARN: Called from:
  /tmp/vagrant-chef-1/chef-solo-1/cookbooks/java/providers/ark.rb:68:in `new'
  /tmp/vagrant-chef-1/chef-solo-1/cookbooks/java/providers/ark.rb:68:in `block in download_direct_from_oracle'
  /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.4.0/lib/chef/mixin/why_run.rb:52:in `call'
  /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.4.0/lib/chef/mixin/why_run.rb:52:in `add_action'

Changed all calls to Chef::ShellOut to Mixlib::ShellOut

@schisamo

schisamo commented Feb 24, 2013

Copy link
Copy Markdown
Contributor

It would be safer to use the Chef::Mixin::ShellOut vs accessing Mixlib::ShellOut directly. Good example in the python cookbook:
https://github.com/opscode-cookbooks/python/blob/master/providers/pip.rb#L23

@colszowka

colszowka commented Mar 21, 2013

Copy link
Copy Markdown

+1 on this, very annoying :)

@eklein

eklein commented Mar 26, 2013

Copy link
Copy Markdown
Contributor Author

Your comment motivated me to finally get this done.. :) closing this PR in favor of PR #46

@eklein eklein closed this Mar 26, 2013
@sroccaserra sroccaserra mentioned this pull request Apr 4, 2013
Closed
@lock

lock Bot commented May 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eklein @schisamo @colszowka