Skip to content
This repository was archived by the owner on Mar 27, 2019. It is now read-only.

use pip via subprocess, not pip.main - #57

Merged
ggilmore merged 2 commits into
masterfrom
pip-no-main
Jun 14, 2018
Merged

ggilmore merged 2 commits into
masterfrom
pip-no-main

Conversation

@ggilmore

@ggilmore ggilmore commented Jun 14, 2018 •

Copy link
Copy Markdown
Contributor

pip doesn't have a public api for a good reason. It has broken at least three times over the past few months, and we gain nothing by using pip as a module versus just using it as a sub-process.

@ggilmore

Copy link
Copy Markdown
Contributor Author

The most recent breakage was due to pip moving the location of the main() function that we were using.

@ggilmore
ggilmore merged commit 3ae1efa into master Jun 14, 2018
@ggilmore
ggilmore deleted the pip-no-main branch June 14, 2018 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants