build: fix building with OpenMP on macOS#1614
Merged
ruevs merged 1 commit intosolvespace:masterfrom Aug 10, 2025
Merged
Conversation
Something changed in the way compiler flags are passed by CMake to the compiler, which caused the OpenMP flags to be passed as a single flag and resulting in a build failure. Use CMake's `SHELL:` syntax to tell CMake to pass these as separate flags, but without reordering them or performing deduplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something changed in the way compiler flags are passed by CMake to the compiler, which caused the OpenMP flags to be passed as a single flag and resulting in a build failure.
Use CMake's
SHELL:syntax to tell CMake to pass these as separate flags, but without reordering them or performing deduplication.