Delete the partially drawn entity when ESC is pressed on pending oper…#1386
Merged
phkahler merged 1 commit intosolvespace:masterfrom Jul 27, 2023
Merged
Delete the partially drawn entity when ESC is pressed on pending oper…#1386phkahler merged 1 commit intosolvespace:masterfrom
phkahler merged 1 commit intosolvespace:masterfrom
Conversation
…ations by using UndoUndo()
Member
|
Hmm... I'll need to pull compile and trace through this if you want an opinion. |
Member
Author
Actually no. It works. |
Member
@phkahler actually no, it makes it impossible to draw open bezier splines 😛 😃 |
Member
Author
Member
|
I'm so used to ESC that I completely forgot about right-click :-) |
ruevs
added a commit
to ruevs/solvespace
that referenced
this pull request
Nov 21, 2024
With this pressing ESC while drawing a bezier curve finishes it instead of deleting it. This reverts the behaviour introduced in b34d9a2 (p.r. solvespace#1386). ESC still deletes the last segment of line segments and cancels arcs and circles. This makes it easier to draw non closed curves - otherwise the only way to finish them was with a right-click.
Member
|
Made a pull request #1497 |
phkahler
pushed a commit
that referenced
this pull request
Nov 21, 2024
With this pressing ESC while drawing a bezier curve finishes it instead of deleting it. This reverts the behaviour introduced in b34d9a2 (p.r. #1386). ESC still deletes the last segment of line segments and cancels arcs and circles. This makes it easier to draw non closed curves - otherwise the only way to finish them was with a right-click.
devin-ai-integration Bot
pushed a commit
to erkinalp/solvespace
that referenced
this pull request
Apr 3, 2025
With this pressing ESC while drawing a bezier curve finishes it instead of deleting it. This reverts the behaviour introduced in b34d9a2 (p.r. solvespace#1386). ESC still deletes the last segment of line segments and cancels arcs and circles. This makes it easier to draw non closed curves - otherwise the only way to finish them was with a right-click.
dennisyangji
pushed a commit
to Orthogonalpub/ode_solvespace
that referenced
this pull request
Nov 25, 2025
With this pressing ESC while drawing a bezier curve finishes it instead of deleting it. This reverts the behaviour introduced in 10f2c44 (p.r. solvespace#1386). ESC still deletes the last segment of line segments and cancels arcs and circles. This makes it easier to draw non closed curves - otherwise the only way to finish them was with a right-click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ations by using UndoUndo()
Fixes #1385