Skip to content

refactor: rename Start mode to app mode - #327

Open
birkskyum wants to merge 2 commits into
nextfrom
app-mode
Open

refactor: rename Start mode to app mode#327
birkskyum wants to merge 2 commits into
nextfrom
app-mode

Conversation

@birkskyum

@birkskyum birkskyum commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Renames the plugin-managed start option to app
  • Renames StartOptions to AppOptions
  • Uses app.root for the root component
  • Groups explicit rendering entries under app.entries.client and app.entries.server
  • Renames errorBoundary to productionErrorBoundary
  • Moves typed env configuration from app.env to the top-level env option
  • Updates internal plugin names, documentation, and example directories
  • Keeps serverFunctions top-level

Why

app describes the optional layer where the plugin owns entries, rendering, dev serving, and build orchestration. It avoids tying that capability to the retired SolidStart name.

env and serverFunctions remain independent capabilities. They can be used by router integrations, manual SSR setups, and other projects without plugin-managed application rendering.

JavaScript configs using start or app.env receive migration errors. No compatibility aliases are retained before the stable release.

Testing

  • pnpm run build
  • pnpm run check
  • app client suite: 46/46
  • env suite: 48/48
  • app SSR suite: 366/366
  • HTTP bridge suite: 10/10

@changeset-bot

changeset-bot Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 88e2de8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/vite-plugin@327

commit: 88e2de8

@birkskyum
birkskyum requested a review from ryansolid August 25, 2026 17:51
@brenelz

brenelz commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

I think it was intentional to use the start name

@birkskyum

birkskyum commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I think it was intentional to use the start name

I understand that start was intentional. My concern is that it is not very descriptive as a configuration category. app groups the settings where the plugin manages the application lifecycle, including entries, document rendering, dev serving, and builds. serverFunctions remains separate because it does not require plugin-managed rendering.

If preserving the Start branding is important, that is a separate consideration (seems like we're beyond it), but I think app communicates the API boundary more clearly.

This was referenced Sep 30, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansolid ryansolid Awaiting requested review from ryansolid

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@birkskyum @brenelz