Fix GitHub link unconditionally navigating to Discord#1483
Merged
LadyBluenotes merged 1 commit intosolidjs:mainfrom Apr 30, 2026
Merged
Fix GitHub link unconditionally navigating to Discord#1483LadyBluenotes merged 1 commit intosolidjs:mainfrom
LadyBluenotes merged 1 commit intosolidjs:mainfrom
Conversation
The GitHub link in the site header across all pages is unconditionally linking to Discord, not GitHub. More details in the issue, but the gist is it appears to be a regression from a large refactor merged 2 days ago: fef6139 All the context was already wired up, it just appears to be using the wrong context variable. An easy fix! Hopefully. Tested locally by smoke testing the link across a few pages and project roots. Closes solidjs#1482
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LadyBluenotes
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GitHub link in the site header across all pages is unconditionally linking to Discord, not GitHub. More details in the issue, but the gist is it appears to be a regression from a large refactor merged 2 days ago: fef6139
All the context was already wired up, it just appears to be using the wrong context field.
Tested locally by smoke testing the link across a few pages and project roots.
Related issues & labels
bug