SNOW-2912540: define ASYNC_RETRY_PATTERN and compat.OK locally#4282
Draft
sfc-gh-fpawlowski wants to merge 1 commit into
Draft
SNOW-2912540: define ASYNC_RETRY_PATTERN and compat.OK locally#4282sfc-gh-fpawlowski wants to merge 1 commit into
sfc-gh-fpawlowski wants to merge 1 commit into
Conversation
These constants were previously imported from snowflake-connector-python. The Universal Driver connector no longer owns them (it has no internal use for either symbol), so define them locally to remove the coupling. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4282 +/- ##
==========================================
+ Coverage 95.16% 95.20% +0.04%
==========================================
Files 171 171
Lines 44158 44463 +305
Branches 7535 7606 +71
==========================================
+ Hits 42022 42331 +309
- Misses 1312 1320 +8
+ Partials 824 812 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two imports from snowflake-connector-python that the Universal Driver connector no longer provides as shims.
async_job.py:ASYNC_RETRY_PATTERNdefined locally (was imported fromconnector.cursor)mock/_telemetry.py:from http.client import OK(was imported fromconnector.compat)Companion changes in snowflake-eng/universal-driver PR #512 and #513.
🤖 Generated with Claude Code