1

Do we really need to automatic define the Content-Type and the Content-Disposition headers in this functions?

What do you think about just to add two functions with StreamFactory inside?

/**
 * @param string $file Path to file
 * @return ResponseInterface
 * @throws \RuntimeException If the file cannot be opened.
 * @throws \InvalidArgumentException If the mode is invalid.
 */
public function withBodyFromFile(string $file): ResponseInterface
{
    return new static(
        $this->response->withBody($this->streamFactory->createStreamFromFile($file)),
        $this->streamFactory
    );
}
/**
 * @param resource $file
 * @return ResponseInterface
 */
public function withBodyFromResource($file): ResponseInterface
{
    return new static(
        $this->response->withBody($this->streamFactory->createStreamFromResource($file)),
        $this->streamFactory
    );
}

Using:

$response->withBodyFromFile('myFile.docx')
         ->withHeader('Content-Type', 'application/msword');

2

For extended functionality, i think it is better to create a new class like this:

class FileResponse extends Response
{
    /**
     * Set Content-Disposition: attachment and insert
     * filename and encoded filename* if $filename is not null
     */
    function withFileName(?string $filename): FileResponse {}
    /** force Content-Length if possible */
    function withContentLength(): FileResponse {}
    /**
     * @param string $contentType Custom type or file extention for autodetect
     * @param bool   $nosniff     Add the X-Content-Type-Options header
     * @return FileResponse
     */
    function withContentType($contentType = 'application/octet-stream', $nosniff = false): FileResponse {}

}

add function createFileResponse($filename, ...) into DecoratedResponseFactory

Add helper to simplify streaming a file download #82

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions