Improve types on routes#3379
Closed
nbayramberdiyev wants to merge 3 commits into
Closed
Conversation
Contributor
|
Hi! For Slim, we only use phpstan and not psalm. We also do not intend to support the psalm-specific "syntax" for the docblocks because it would be too much effort to maintain both. Thank you for your understanding. |
Contributor
Author
I'm having some trouble understanding this. The syntax isn't specific to Psalm, it's also used by PHPStan. That said, the current definition of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My routes are defined as follows:
->get('/', [HomeController::class, 'index']);, which is a valid route definition. However, the latest version of Psalm emits the following error:This PR addresses this issue by adding the
array{class-string, string}type to the route handler definition.