Skip to content

Refactor#3220

Merged
akrabat merged 5 commits into
slimphp:4.xfrom
amirkhodabande:refactor
Nov 7, 2022
Merged

Refactor#3220
akrabat merged 5 commits into
slimphp:4.xfrom
amirkhodabande:refactor

Conversation

@amirkhodabande
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread tests/Handlers/Strategies/RequestResponseNamedArgsTest.php Outdated
Copy link
Copy Markdown
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the constant name, please rebase against 4.x and fix conflicts.

@akrabat akrabat added the pending response Waiting on a response from the original poster label Nov 5, 2022
@amirkhodabande
Copy link
Copy Markdown
Contributor Author

In addition to the constant name, please rebase against 4.x and fix conflicts.

# Conflicts:
#	tests/Middleware/MethodOverrideMiddlewareTest.php
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.36% when pulling 2739c2c on amirkhodabande:refactor into b0f4ca3 on slimphp:4.x.

Copy link
Copy Markdown
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@akrabat akrabat merged commit 75d5613 into slimphp:4.x Nov 7, 2022
@akrabat akrabat added this to the 4.12.0 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending response Waiting on a response from the original poster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants