weirdan/prophecy-shim must be a dev requirement#3029
Merged
Conversation
As it is to support both PHPUnit 8 & 9, that dependency must be in dev requirement.
Contributor
|
@l0gicgate sorry, I missed this! |
Contributor
Author
|
@l0gicgate I think it should go into 4.7.1 rather than 4.8.0. In my case, I can't upgrade to 4.7.0 because the inclusion of that deps breaks the build of my project. I might not be the only one. Also it's a huge addition in the composer.lock: What do you think? |
Member
|
@j0k3r I just changed the milestone to 4.7.1. Will be releasing tonight. |
chriscct7
pushed a commit
to awesomemotive/aioseo-slim-v3-php-8.1
that referenced
this pull request
Sep 3, 2025
weirdan/prophecy-shim must be a dev requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it is to support both PHPUnit 8 & 9, that dependency must be in dev requirement.
It breaks code from project using Slim with PHPUnit-Bridge for example. Anyway a PHPUnit related deps must not be in
requirebut inrequire-dev.Following #3015
Related to that commit d971acb