Skip to content

use stdClass as a dummy during testing for non-existent classes.#1977

Closed
robertprice wants to merge 1 commit into
slimphp:3.xfrom
robertprice:mockClassesExist
Closed

use stdClass as a dummy during testing for non-existent classes.#1977
robertprice wants to merge 1 commit into
slimphp:3.xfrom
robertprice:mockClassesExist

Conversation

@robertprice
Copy link
Copy Markdown
Contributor

phpunit 5.5.2 on PHP7 complains if non-existent classes are mocked, giving an undefined index error. I have replaced two mock classes that don't exist with stdClass to mitigate this.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.18% when pulling 338562a on robertprice:mockClassesExist into 1dedd25 on slimphp:3.x.

@robertprice robertprice closed this Sep 2, 2016
@robertprice robertprice deleted the mockClassesExist branch September 2, 2016 15:06
@akrabat
Copy link
Copy Markdown
Member

akrabat commented Sep 4, 2016

Why did you close this?

@akrabat
Copy link
Copy Markdown
Member

akrabat commented Sep 4, 2016

Ah - Replaced with #1978

@robertprice
Copy link
Copy Markdown
Contributor Author

Yes :-)

On Sunday, 4 September 2016, Rob Allen [email protected] wrote:

Ah - Replaced with #1978 #1978


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1977 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABXCBY32toitOfmFlucbtItvKi5WVkihks5qmovogaJpZM4JzwJj
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants