Skip to content

Related to #1962. Implementation with UnitTest#1963

Merged
akrabat merged 3 commits into
slimphp:3.xfrom
geggleto:feature-1962
Oct 11, 2016
Merged

Related to #1962. Implementation with UnitTest#1963
akrabat merged 3 commits into
slimphp:3.xfrom
geggleto:feature-1962

Conversation

@geggleto
Copy link
Copy Markdown
Member

@geggleto geggleto commented Aug 16, 2016

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.005%) to 97.185% when pulling b4f1810 on geggleto:feature-1962 into 1dedd25 on slimphp:3.x.

@akrabat
Copy link
Copy Markdown
Member

akrabat commented Aug 17, 2016

Please put setCallable() immediately after getCallable().

Also, while we're here, can we add a protected property for $this->callable?

@mathmarques
Copy link
Copy Markdown
Contributor

@akrabat $callable is already protected, see here.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 97.183% when pulling 103269e on geggleto:feature-1962 into 1dedd25 on slimphp:3.x.

@geggleto
Copy link
Copy Markdown
Member Author

@mathmarques makes more sense to surface it for readability... I thought it was super weird that it was buried.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 97.183% when pulling 0b4395d on geggleto:feature-1962 into 1dedd25 on slimphp:3.x.

@akrabat
Copy link
Copy Markdown
Member

akrabat commented Aug 17, 2016

ah! - it's in the parent…

@geggleto
Copy link
Copy Markdown
Member Author

@akrabat I moved the method as well ;)

@akrabat akrabat merged commit 0b4395d into slimphp:3.x Oct 11, 2016
akrabat added a commit that referenced this pull request Oct 11, 2016
@akrabat akrabat added this to the 3.5.1 milestone Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants