save the user profile data within the User object#341
Closed
fixedd wants to merge 1 commit into
Closed
Conversation
|
|
Author
|
Travis is only failing on an SSL cert error that's unrelated, this should not count. |
Contributor
|
Thank you very much for taking the time to make this PR. This project no longer supports version 1.x as we've described here. Allow me to close this now. If you see the necessity to fix something similar in v2, please let us know by raising a new issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Save the user profile data within the user object.
The API changelog from almost a year ago describes how @mentions are changing and we need to use the new model before September 12, 2018, but it's impossible to get at the necessary profile data with the present implementation. This implementation isn't perfect (just shoving all the profile data into a dict in the User model), but it's backwards compatible and will allow us the ability to construct @mentions that will still function a month (and some change) from now).
Considering the timeliness of the API change SOME measure is needed, even if not ideal, IMHO.
Requirements (place an
xin each[ ])