Skip to content

Minor readability fixes#291

Closed
xifumi wants to merge 2 commits into
slackapi:masterfrom
xifumi:master
Closed

Minor readability fixes#291
xifumi wants to merge 2 commits into
slackapi:masterfrom
xifumi:master

Conversation

@xifumi

@xifumi xifumi commented Feb 13, 2018

Copy link
Copy Markdown

Summary

  • Field set intersection is much more readable
  • Minor test to catch mixed csv/lists plural fields
  • PEP8 autoformating.

Requirements (place an x in each [ ])

- Field set intersection is more readable now
- Minor test to catch mixed cvs/lists plural fields
@CLAassistant

CLAassistant commented Feb 13, 2018

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


shiv seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov

codecov Bot commented Feb 13, 2018

Copy link
Copy Markdown

Codecov Report

Merging #291 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   59.82%   59.94%   +0.11%     
==========================================
  Files          10       10              
  Lines         341      342       +1     
  Branches       62       62              
==========================================
+ Hits          204      205       +1     
  Misses        121      121              
  Partials       16       16
Impacted Files Coverage Δ
slackclient/slackrequest.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a27b1f...16fa851. Read the comment docs.

@xifumi

xifumi commented Feb 13, 2018

Copy link
Copy Markdown
Author

Ummmm ... I signed the CLA but for some reason CLA is trying to look for shiv instead of xifumi

@Roach Roach closed this Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants