Repository navigation
refactor!: rebuild skill on shared agents core - #29
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skillbecomes the skills edition ofagents: a thin command layer over agents-tools/core, as specified in core'sDocumentation/Proposals/AgentInstructions.md(Products, Commands).Sources/Coreand its tests; depends on core'sAgentsCoreandAgentsSkills(coremasterduring development; release preparation pins a minor-bounded version range).skill add|list|remove|update|initbehave asagents skills …;skill install|update|doctorbehave as the top-levelagentscommands restricted to skills. Options, help, output, JSON schemas, remedies and exit codes matchagents. Instruction selections, locked instruction records and target files stay untouched.agents.json/agents.resolved(project.agent/, user~/.agents/); 0.2 state files are not read. The 0.2 watch ledger and review commands are removed; watch returns as a subscription in a follow-up PR before 0.3.0.swift-format lint --strictandswift build -c releaseon every PR.Documentation/Reference/Release.mddocuments releasingskill.skills/skill-clicompanion describe the new surface.Issues
Resolved here: Resolves #19, Resolves #20, Resolves #21, Resolves #22, Resolves #23, Resolves #24, Resolves #25, Resolves #26.
Resolved in core and adopted by this change: Resolves #4, Resolves #7, Resolves #8, Resolves #14, Resolves #17 (core PRs agents-tools/core#4 and agents-tools/core#7).
Superseded by the proposal, to be closed with a link after merge: #9 (preview may fetch into mirrors; state stays untouched), #18 (watch is a subscription, not an install gate).
Still open, for a follow-up core change: #15 (core rejects a conflicting owner but names only the existing one; the issue asks for both) and #16 (needs a targeted core regression test for unqualified adds after other requirement kinds).
Validation
swift build,swift test(agent configuration variables unset) → 28 tests pass;swift build -c release→ pass; strict lint → 0 findings;git diff --check→ clean.CODEX_HOME,CLAUDE_CONFIG_DIRandXDG_*directories left every sentinel unchanged.skilland withagents skillsproduced byte-identicalagents.json,agents.resolvedand installed trees at every step, in project and user scope.