Repository navigation
fix(lock): reject unreadable resolved files before writing - #12
Merged
Merged
Conversation
Reject undecodable resolved files before changing installed files, preserve their contents on failure, and surface invalid state in listing and diagnostic reports while retaining supported legacy decoding and deterministic output. Resolves #5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An existing
skills.resolvedthat could not be decoded was treated as empty state. The next successfuladdoverwrote it and lost every previous pin, and read commands hid the problem (skill listprinted "No project skills found" and exited 0).Now:
Invalid state: resolved file <path> could not be decoded. The file is never replaced. Legacy-schema content at the current path still decodes; when the current file exists the legacy file is not read.add(including--watchand--watch-only),install,update --apply,update --from-watch --applyandremove.skill listandskill list --allexit non-zero with the decode error.skill doctorreportsresolved-fileaserrorwithok: falseand a repair hint..agent/skills.resolved, which discovery uses only to skip installed copies inside the source, is a hint: if it cannot be decoded, discovery ignores it, soskill add <source>andskill list <source>keep working for third-party repositories.Validation
swift build— passswift test— 127 tests in 17 suites passxcrun swift-format lint --configuration .swift-format --recursive Package.swift Sources Tests— exit 0, no new warnings in changed filesgit diff --check— cleanHOME: with a corrupted project resolved file,list,add,add . --watch-only,remove,installandupdate --applyfail, nothing is installed or removed, no watch ledger is created and the file stays byte-identical; with valid project state,add/listfrom a source whose own resolved file is corrupted succeed.Resolves #5